Monkey emote sounds#5928
Open
pootslap wants to merge 2 commits into
Open
Conversation
adding the params to emoteSounds overrides every individual emote which sucks
|
Triaged by stop_sign: |
|
CR consensus: Approved Review closed by stop_sign. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Monkeys now make sounds when they emote.
Why / Balance
As a retired Pun Pun main he deserves to be able to make annoying sounds like everybody else. Scurrets have a whole fancy suite of emotes and with the new bartender assistant Baba, I figured Pun Pun should get something new.
Technical details
Added a new set of emoteSounds. I had to apply it to monkeys and syndicate monkeys rather than MobAncestorBase (otherwise kobolds would get it too).
There's a bunch of nonsense with sounds having params set individually. Setting it for the whole group of sounds overrides any pitch changes so eh.
No new sounds, just some minor pitch shifting. The cough is a monkey screech used in some old virology stuff. That one might be a bit annoying but it's probably fine if the emote cooldown gets put back in.
Media
monkeygoesook.mp4
Requirements
Licensing
Changelog
🆑