test: JaCoCo 테스트 설정 점검 및 커버리지 검증#97
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request establishes a robust testing framework by integrating Jacoco for code coverage and transitioning the test environment to an H2 in-memory database. It introduces a standardized BaseControllerTest and implements extensive unit and integration tests across all major domains, including Address, AI, Auth, Menu, Order, and Payment. The review feedback suggests including the core AiService in coverage verification to ensure critical logic is tested and recommends using imports instead of fully qualified class names in test files to improve code readability.
| "**/entity/**", | ||
| "**/exception/**", | ||
| "**/handler/**", | ||
| "**/ai/service/AiService*" |
Contributor
|
|
||
| // when & then | ||
| assertThatThrownBy(() -> menuService.createMenu(storeId, request, "hacker")) | ||
| .isInstanceOf(com.sparta.delivhub.common.dto.BusinessException.class); |
Contributor
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 PR 제목
🔗 관련 이슈
📌 작업 내용 요약
🧱 변경 범위 (Scope)
Backend
🧪 테스트 내역
Backend
테스트 상세(필수)
✅ 리뷰어 체크 포인트 (선택)