Open
Add test coverage for ignore-filepaths matching nested subdirectory files#22
Conversation
Super-linter summary
Super-linter detected linting errors For more information, see the Powered by Super-linter TRIVY |
Copilot
AI
changed the title
[WIP] Add a test for ignore-paths with subdirectory files
Add test coverage for ignore-filepaths matching nested subdirectory files
Jul 1, 2026
aebrahim
approved these changes
Jul 2, 2026
aebrahim
approved these changes
Jul 2, 2026
GhaithqD
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ignore-filepathslacked test coverage confirming that files nested inside an ignored directory (not just direct top-level matches) are correctly excluded from the CODEOWNERS check.Test changes
'skips check when all changed files are in an ignored subdirectory'in__tests__/main.test.ts, mirroring the existing top-level ignore test but using a deeply nested changed file path against adist/**pattern to validate theminimatch-basedisIgnoredlogic insrc/main.tscorrectly matches across directory depth.No production code changes were required — the existing
isIgnoredimplementation already handles this case correctly; this PR closes the test coverage gap.