Fix XRPL EVM chain icons (1440000 / 1449000 / 1449900)#2845
Open
vriveraPeersyst wants to merge 2 commits into
Open
Fix XRPL EVM chain icons (1440000 / 1449000 / 1449900)#2845vriveraPeersyst wants to merge 2 commits into
vriveraPeersyst wants to merge 2 commits into
Conversation
ChainList renders chain logos from the `constants/chainIds.js` slug (`https://icons.llamao.fi/icons/chains/rsz_${chainSlug}.jpg`), not from the ethereum-lists / override `icon` field. The XRPL EVM entries were broken: - 1440000 used slug `xrpl_evm` -> rsz_xrpl_evm.jpg returns 404 - 1440002 / 1449000 had no slug at all -> fell back to /unknown-logo.png Fix the slugs to match DefiLlama's registered icon files: - 1440000: `xrpl_evm` -> `xrpl evm` (matches DefiLlama chain name, so it also restores the TVL lookup) - 1440002: add `xrpl-evm` (devnet icon) - 1449000: add `xrpl-evm` (testnet icon; hyphen avoids falsely matching the mainnet's TVL) Also align the mainnet override `icon` field with ethereum-lists (`xrplevm`) for API/data consistency. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The devnet entry used the old chain id 1440002. Update it to 1449900 so the icon slug resolves against the correct chain. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
9e49527 to
e0a297e
Compare
atze1210
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
XRPL EVM Mainnet (
1440000), Testnet (1449000) and Devnet (1449900) all render the default/unknown-logo.pnginstead of the XRPL EVM logo.Root cause
ChainList builds the chain logo from
constants/chainIds.js(the chain slug), not from theiconmetadata field:1440000had slugxrpl_evm→rsz_xrpl_evm.jpgreturns 404.1449000/1449900had nochainIds.jsentry →chainSlugis undefined → falls back to/unknown-logo.png.The real CDN files are
rsz_xrpl-evm.jpg/rsz_xrpl%20evm.jpg(both HTTP 200). DefiLlama's own chain name for1440000isXRPL EVM(api.llama.fi/chains), and thechainIds.jsconvention is the DefiLlama name lowercased with spaces preserved (e.g.nova network,x layer,zksync era).Fix
constants/chainIds.js:1440000:xrpl_evm→xrpl evm— matches DefiLlama's chain name, so it fixes the icon and restores the TVL lookup.1449900: addxrpl-evm(devnet icon).1449000: addxrpl-evm(testnet icon; the hyphen intentionally differs fromxrpl evmso the testnets don't falsely inherit the mainnet's TVL).Also aligns the
1440000overrideiconfield with ethereum-lists (xrplevm) for API/data consistency — no display impact.Verification
node tests/check-duplicate-keys.jspasses.🤖 Generated with Claude Code