finding groups: filter by product if applicable #12711
Open
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
No security concerns detected in this pull request. All finding details can be found in the DryRun Security Dashboard. |
Maffooch
approved these changes
Jun 30, 2025
hblankenship
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly fixes: #10268
This PR limits the list of Finding Group options in the Finding Filter to those groups that belong to the Product the user is viewing.
This also applies to when viewing findings by Test or by Enagement. In that case Finding Groups from the whole product will be shown. This is because currently the FindingFilter class is not aware of which Engagement or Test is being viewed. It only has the Product as context via
self.pid. I didn't want to refactor too many things and I think limiting the list to the Product context is already a good improvement.