Skip to content

fix(nix): bump nixpkgs pin so nix-shell-test builds with go >= 1.25.9 - #2226

Merged
lionello merged 1 commit into
mainfrom
fix/nix-flake-go-version
Aug 19, 2026
Merged

fix(nix): bump nixpkgs pin so nix-shell-test builds with go >= 1.25.9#2226
lionello merged 1 commit into
mainfrom
fix/nix-flake-go-version

Conversation

@defangdevs

Copy link
Copy Markdown
Contributor

Problem

nix-shell-test is failing on main and on every open PR (including #2225) with:

go: go.mod requires go >= 1.25.9 (running go 1.25.5; GOTOOLCHAIN=local)

Root cause

Dependabot's github.com/moby/buildkit bump in #2224 pulled in buildkit v0.31.1, whose own go.mod requires go 1.25.9 — this transitively raised our module's effective minimum toolchain requirement. That's unrelated to any single PR's diff; it landed on main itself.

flake.lock's nixpkgs input was pinned to a January 2026 revision that only ships go_1_25 1.25.5. The Nix sandbox has no network access to auto-fetch a newer toolchain (GOTOOLCHAIN=local), so the build fails outright before it even gets to vendor-hash verification — the CI job's existing "Update vendorHash if needed" auto-fix step never even triggers, since the failure isn't a hash mismatch.

Fix

Verified locally:

nix build .#defang-cli   # succeeds
nix run .#defang-cli -- --version   # defang version development

Test plan

  • nix build .#defang-cli succeeds locally with the updated pin
  • nix-shell-test passes in CI on this PR

…1.25.9

github.com/moby/buildkit v0.31.1 (bumped by dependabot in #2224) requires
go >= 1.25.9 in its own go.mod, which raised our module's go directive to
1.25.9 too. The nixpkgs revision pinned in flake.lock only shipped go_1_25
1.25.5, so the nix-shell-test CI job failed on every PR/push to main with
"go.mod requires go >= 1.25.9 (running go 1.25.5; GOTOOLCHAIN=local)" before
it ever got far enough to check the vendor hash.

Update the nixpkgs pin to a revision that ships go_1_25 1.25.13, and update
the resulting vendorHash for the go.sum changes from the buildkit bump.
Verified locally with `nix build .#defang-cli`.
@defangdevs
defangdevs requested a review from lionello as a code owner August 19, 2026 23:18
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@defangdevs, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 25 minutes

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e6a4a318-c1f6-4a56-bf2d-dc7139eedba8

📥 Commits

Reviewing files that changed from the base of the PR and between 77957a2 and dcd65eb.

⛔ Files ignored due to path filters (1)
  • flake.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pkgs/defang/cli.nix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lionello
lionello enabled auto-merge (squash) August 19, 2026 23:22
@lionello
lionello merged commit d1dd61b into main Aug 19, 2026
7 checks passed
@lionello
lionello deleted the fix/nix-flake-go-version branch August 19, 2026 23:23
defangdevs added a commit that referenced this pull request Aug 21, 2026
Four merges landed on main after the previous merge: #2225, #2226, #2224
(buildkit bump) and #2221. The conflicts were all dependency state, none
in the cleanup code:

- src/go.mod, src/go.sum: this branch carried AWS SDK pins from when it
  was opened in June, main has newer ones. Resolved to main's versions
  and re-ran `go mod tidy`, which re-added the ecr, elbv2 and rds modules
  this branch needs at their current versions.
- pkgs/defang/cli.nix: took main's vendorHash as the closer starting
  point. The Update vendorHash step in go.yml corrects and commits it if
  the tidy moved it.

src/pkg/cli/client/byoc/aws/byoc.go merged cleanly.

`go build ./...` and `go test -short ./...` green.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01T3WmpdY3zc555sNdkY9dzQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants