Skip to content

fix: warn when project or service name exceeds 16 characters #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lionello merged 1 commit into from
Apr 29, 2026
Merged

fix: warn when project or service name exceeds 16 characters #2080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/pkg/cli/compose/fixup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ func FixupServices(ctx context.Context, provider client.Provider, project *compo
accountInfo = &client.AccountInfo{}
}

if len(project.Name) > 16 {
term.Warnf("project name %q is longer than 16 characters, you may run into issues with resource name length", project.Name)
}
Comment thread
lionello marked this conversation as resolved.

// Fixup any pseudo services (this might create port configs, which will affect service name replacement by ReplaceServiceNameWithDNS)
for _, svccfg := range project.Services {
repo := GetImageRepo(svccfg.Image)
Expand All @@ -68,6 +72,10 @@ func FixupServices(ctx context.Context, provider client.Provider, project *compo
}
}

if len(svccfg.Name) > 16 {
term.Warnf("service %q: service name is longer than 16 characters, you may run into issues with resource name length", svccfg.Name)
}

if svccfg.Provider != nil && svccfg.Provider.Type == "model" && svccfg.Image == "" && svccfg.Build == nil {
fixupModelProvider(&svccfg, project, accountInfo)
}
Expand Down
1 change: 1 addition & 0 deletions src/testdata/ambiguous-strings/compose.yaml.warnings
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
! project name "ambiguous-strings" is longer than 16 characters, you may run into issues with resource name length
! service "a": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "b": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
1 change: 1 addition & 0 deletions src/testdata/compose-go-warn/compose.yaml.warnings
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
! "yes" for boolean is not supported by YAML 1.2, please use `true`
! project name "compose-go-warning" is longer than 16 characters, you may run into issues with resource name length
! service "echo": ingress port 80 without healthcheck; defaults to GET / HTTP/1.1
! service "echo": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
2 changes: 2 additions & 0 deletions src/testdata/dockerfile-validation-errors/compose.yaml.warnings
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
! project name "dockerfile-validation-errors" is longer than 16 characters, you may run into issues with resource name length
! service "invalid-dockerfile": ingress port 8080 without healthcheck; defaults to GET / HTTP/1.1
! service "invalid-dockerfile": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "invalid-dockerfile": service name is longer than 16 characters, you may run into issues with resource name length
2 changes: 2 additions & 0 deletions src/testdata/fixupenv/compose.yaml.warnings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
! service "ingress-service": ingress port 5432 without healthcheck; defaults to GET / HTTP/1.1
! service "ingress-service": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "refer-self-build-arg": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "refer-self-build-arg": service name is longer than 16 characters, you may run into issues with resource name length
! service "refer-self-env": ingress port 5678 without healthcheck; defaults to GET / HTTP/1.1
! service "refer-self-env": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "ui": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "use-ingress-service": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "use-ingress-service": service name is longer than 16 characters, you may run into issues with resource name length
2 changes: 2 additions & 0 deletions src/testdata/llm/compose.yaml.warnings
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
! service "alt-repo": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "gateway-with-ports": ingress port 5678 without healthcheck; defaults to GET / HTTP/1.1
! service "gateway-with-ports": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "gateway-with-ports": service name is longer than 16 characters, you may run into issues with resource name length
! service "gateway-without-ports": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "gateway-without-ports": service name is longer than 16 characters, you may run into issues with resource name length
! service "llm": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
1 change: 1 addition & 0 deletions src/testdata/longname/compose.yaml.warnings
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
! service "aVeryLongServiceNameThatIsDefinitelyTooLongThatWillCauseAnError": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "aVeryLongServiceNameThatIsDefinitelyTooLongThatWillCauseAnError": service name is longer than 16 characters, you may run into issues with resource name length
1 change: 1 addition & 0 deletions src/testdata/mongo/compose.yaml.warnings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,6 @@
! service "mongo-unmanaged": stateful service will lose data on restart; use a managed service instead
! service "mongo-wrong-image": managed MongoDB service should use a mongo image
! service "mongo-wrong-image": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "mongo-wrong-image": service name is longer than 16 characters, you may run into issues with resource name length
! service "short-ports": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "short-ports": stateful service will lose data on restart; use a managed service instead
1 change: 1 addition & 0 deletions src/testdata/networks/compose.yaml.warnings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@
! service "service-private": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "service-public": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "service-public-list": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "service-public-list": service name is longer than 16 characters, you may run into issues with resource name length
1 change: 1 addition & 0 deletions src/testdata/ports/compose.yaml.warnings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@
! service "short-published": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "short-udp": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "short-udp-published": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "short-udp-published": service name is longer than 16 characters, you may run into issues with resource name length
1 change: 1 addition & 0 deletions src/testdata/postgres/compose.yaml.warnings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
! service "no-ext": stateful service will lose data on restart; use a managed service instead
! service "no-ports": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "no-ports-override": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "no-ports-override": service name is longer than 16 characters, you may run into issues with resource name length
! service "short-ports": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "with-ext": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "wrong-image": managed Postgres service should use a postgres image
Expand Down
1 change: 1 addition & 0 deletions src/testdata/railpack/compose.yaml.warnings
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
! service "railpack-long": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "railpack-short": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "railpackwithdockerfile": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "railpackwithdockerfile": service name is longer than 16 characters, you may run into issues with resource name length
1 change: 1 addition & 0 deletions src/testdata/redis/compose.yaml.warnings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
! service "no-ext": stateful service will lose data on restart; use a managed service instead
! service "no-ports": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "no-ports-override": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "no-ports-override": service name is longer than 16 characters, you may run into issues with resource name length
! service "short-ports": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "valkey-service": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
! service "with-ext": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors
Expand Down
Loading