Skip to content

fix: Server-owned pawns ability activation dropping silently. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Crezetique wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix: Server-owned pawns ability activation dropping silently. #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b77bfcd
fix: Server-owned pawns ability activation dropping silently.
Crezetique May 21, 2026
a05959e
- Fixed Client Abilities on MovementTick throwing mismatch Operation ID.
Crezetique May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions Source/GMCAbilitySystem/Private/Components/GMCAbilityComponent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1945,15 +1945,9 @@ bool UGMC_AbilitySystemComponent::ProcessOperation(FInstancedStruct OperationDat
const UScriptStruct* StructType = PayloadData.GetScriptStruct();

// Activate Ability — handled in any tick context (AncillaryTick or PredictionTick),
// so consume the cache entry here on the auth side.
// so consume the cache entry here on the auth side, but only if ability activation succeeds.
if (StructType == FGMASBoundQueueV2AbilityActivationOperation::StaticStruct())
{
// Server only ever processes operations once so it doesn't need them cached
if (HasAuthority())
{
BoundQueueV2.RemovePayloadByID(OperationID);
}

const FGMASBoundQueueV2AbilityActivationOperation Data = PayloadData.Get<FGMASBoundQueueV2AbilityActivationOperation>();
if (!BoundQueueV2.bInBatchDispatch)
{
Expand All @@ -1970,8 +1964,20 @@ bool UGMC_AbilitySystemComponent::ProcessOperation(FInstancedStruct OperationDat
OperationID, *Data.InputTag.ToString(),
HasAuthority() ? 1 : 0, bFromMovementTick ? 1 : 0, bForce ? 1 : 0);
}

const bool bActivated = TryActivateAbilitiesByInputTag(Data.InputTag, Data.InputAction, bFromMovementTick, bForce);

// The ability can fail if it is running on the irrelevant tick, hence we preserve the payload when necessary.
if (HasAuthority())
{
const bool bPreserveForAncillaryTick = !bActivated && bFromMovementTick;
if (!bPreserveForAncillaryTick)
{
BoundQueueV2.RemovePayloadByID(OperationID);
}
}

return TryActivateAbilitiesByInputTag(Data.InputTag, Data.InputAction, bFromMovementTick, bForce);
return bActivated;
}

// Everything below happens only during the Prediction tick (or via the forced
Expand Down