Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: matrix of all the good eigenvectors #11

Open
afraser3 opened this issue Sep 21, 2022 · 1 comment
Open

Feature request: matrix of all the good eigenvectors #11

afraser3 opened this issue Sep 21, 2022 · 1 comment

Comments

@afraser3
Copy link
Collaborator

Sometimes I want to do matrix manipulations that involve using a matrix whose columns are various eigenvectors from the EVP solver. A good example can be found here in calc_ps(), specifically lines 399, 402, and 414. If I just do EP.solver.eigenvectors, then those eigenvectors don't necessarily match up with the eigenvalues in EP.evalues, which are the eigenvalues of EP.hires_solver (assuming reject=True). This can cause unintended behavior.

It would be great if I could just get EP.evectors and have that be the eigenvectors that correspond to EP.evalues whether reject=True or reject=False. And in case it's True, I'm thinking it would be great for EP.evectors to be the higher-resolution eigenvectors, but maybe other users have a reason why they'd also want access to the lower-resolution eigenvectors.

@afraser3
Copy link
Collaborator Author

I have used eigenvectors = ((EP.solver.eigenvectors.T)[EP.evalues_index]).T in the past, which I believe reliably sorts the low-res solver's eigenvectors to line up with EP.evalues. Perhaps this is all there is to it. I guess I'm still worried about differences between the low-res and high-res solvers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant