You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is closely related to #11 -- it's possible that there are instances in eigenproblem where self.solver should really be self.hires_solver. If reject=True (the default), it may be sensible to have self.lowres_solver and self.solver, where the new self.lowres_solver is the old self.solver, and the new self.solver is the old self.hires_solver.
There are two particular occurrences that come to mind. First, in EP.eigenmode(), this change would let you work with the higher-resolution mode, and maybe that's preferred.
Second, in calc_ps(), the eigenmodes of self.solver are used throughout. If self.evalues are significantly different than self.evalues_low, then plots that show pseudospectra alongside self.evalues (like in the Eigentools documentation) won't make as much sense as they would if calc_ps() used self.hires_solver, or if the pseudospectra were shown alongside self.evalues_low.
This might cause unintended behavior in EP.project_mode(), if the user suddenly finds themselves trying to project a higher-resolution-than-intended mode onto a given domain.
The text was updated successfully, but these errors were encountered:
This is closely related to #11 -- it's possible that there are instances in
eigenproblem
whereself.solver
should really beself.hires_solver
. Ifreject=True
(the default), it may be sensible to haveself.lowres_solver
andself.solver
, where the newself.lowres_solver
is the oldself.solver
, and the newself.solver
is the oldself.hires_solver
.There are two particular occurrences that come to mind. First, in
EP.eigenmode()
, this change would let you work with the higher-resolution mode, and maybe that's preferred.Second, in
calc_ps()
, the eigenmodes ofself.solver
are used throughout. Ifself.evalues
are significantly different thanself.evalues_low
, then plots that show pseudospectra alongsideself.evalues
(like in the Eigentools documentation) won't make as much sense as they would ifcalc_ps()
usedself.hires_solver
, or if the pseudospectra were shown alongsideself.evalues_low
.This might cause unintended behavior in
EP.project_mode()
, if the user suddenly finds themselves trying to project a higher-resolution-than-intended mode onto a given domain.The text was updated successfully, but these errors were encountered: