Warning when factorial arguments conflict #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning for which value takes precedence when user inputs both `sd` and `outcome_sds` and they do not match.
nfultz
reviewed
Aug 2, 2019
| if(max(c(sd_i, outcome_sds) < 0) ) stop("sd_i and outcome_sds must be nonnegative") | ||
| if(max(c(prob_A, prob_B) < 0)) stop("prob_ arguments must be nonnegative") | ||
| if(max(c(prob_A, prob_B) > 1)) stop("prob_ arguments must not exceed 1") | ||
| if(!is.null(outcome_means) && all(!is.null(c(mean_A0B0, mean_A0B1, mean_A1B0, mean_A1B1))) && |
Contributor
There was a problem hiding this comment.
Not sure this check will work as intended, it is not user friendly to require people to set outcome_means=NULL when they want to provide all 4 means.
Also is.null is not vectorized, would double check the second half as well.
> is.null(c(2, NULL))
[1] FALSE
Adding some tests that set the mean_AB params should help shake out these issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return warning for which value takes precedence when user inputs both
sdandoutcome_sdsand they do not match.