-
Notifications
You must be signed in to change notification settings - Fork 293
Sentinel and server at parallele #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I've already done the same thing in our code base. |
My only concern with this is that it changes behavior for users that relied only on the |
At my workplace we're also running the same configuration -- we have a number of dev redis clusters that run sentinel and redis on the same VM. This patch applies cleanly and works well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to get this merged, is there anything else we can do?
As you say @DavidWittman, for those relying only on redis_sentinel
flag it can be a problem, maybe we could add a comment in the README to warn about this change?
@@ -19,6 +19,8 @@ redis_nofile_limit: 16384 | |||
|
|||
## Role options | |||
# Configure Redis as a service | |||
redis_server: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like the line is in the middle of a comment, maybe move it just below ## Role options
?
Hello. Any update on this PR ? It would be good to have it ... |
Hello,
I would be good to be able to run a redis-server instance on default port (6379) and sentinel instance at the same time.
I propose a modification of the role to handle this capacity.