Skip to content

Sentinel and server at parallele #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Sentinel and server at parallele #185

wants to merge 2 commits into from

Conversation

jorijinnall
Copy link

Hello,

I would be good to be able to run a redis-server instance on default port (6379) and sentinel instance at the same time.
I propose a modification of the role to handle this capacity.

@eRadical
Copy link
Contributor

eRadical commented Mar 17, 2018

I've already done the same thing in our code base.
Would love to see it merged.

@DavidWittman
Copy link
Owner

My only concern with this is that it changes behavior for users that relied only on the redis_sentinel flag, but I don't think that's too big of a deal. I'll get this merged after I confirm the test-kitchen runs still work and the documentation is updated.

@nogweii
Copy link

nogweii commented Jul 9, 2018

At my workplace we're also running the same configuration -- we have a number of dev redis clusters that run sentinel and redis on the same VM. This patch applies cleanly and works well.

Copy link
Contributor

@bew bew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to get this merged, is there anything else we can do?

As you say @DavidWittman, for those relying only on redis_sentinel flag it can be a problem, maybe we could add a comment in the README to warn about this change?

@@ -19,6 +19,8 @@ redis_nofile_limit: 16384

## Role options
# Configure Redis as a service
redis_server: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like the line is in the middle of a comment, maybe move it just below ## Role options ?

@smutel
Copy link

smutel commented Mar 22, 2021

Hello. Any update on this PR ? It would be good to have it ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants