fix(server): clean exit on stdin EOF; bump 0.2.0 -> 0.2.1 - #20
Merged
Merged
Conversation
server.py exits via os._exit(0) once asyncio.run(main()) returns. After the host closes stdin (EOF), anyio's stdin worker thread can be parked on the now-closed handle and the transport's TextIOWrapper has closed sys.stdout; falling through to interpreter shutdown raised a noisy post-result 'ValueError: I/O operation on closed file'. os._exit runs no finalizers and touches no std stream, so neither hazard fires; a real failure still propagates out of asyncio.run above the exit. test_frozen_server.py adds tier T5: spawn the target with stdin closed at once, assert rc=0 with no teardown traceback (per-platform guard, bites on the frozen binary). 0.2.0 -> 0.2.1 (patch): folds the post-v0.2.0 fixes (Findings A/B/C + this) under one label; SERVER_VERSION and manifest bumped together, T0 refuses a half-bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deterministic clean exit on stdin EOF (os._exit(0) once server.run returns), guarded by a new frozen-server tier T5. Version bumped 0.2.0 -> 0.2.1 to fold the post-v0.2.0 fixes (Findings A/B/C + this) under one label. Floor 270/270 green; T0/T5 green on the Windows dev server.