Skip to content

Conversation

@thapacodes4u
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 76.92308% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.41%. Comparing base (33b224e) to head (39ddca9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/View/Components/BrandWithTenantSwitcher.php 77.55% 11 Missing ⚠️
src/EclipseServiceProvider.php 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #26      +/-   ##
============================================
+ Coverage     72.36%   72.41%   +0.05%     
- Complexity      303      322      +19     
============================================
  Files            56       57       +1     
  Lines          1914     1947      +33     
============================================
+ Hits           1385     1410      +25     
- Misses          529      537       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@SlimDeluxe SlimDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tenant switching works, but the frontend link is not being shown. See comments below.

@thapacodes4u
Copy link
Contributor Author

@SlimDeluxe This is ready for review

Copy link
Member

@SlimDeluxe SlimDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The frontend link issue remains, please fix.

@thapacodes4u
Copy link
Contributor Author

thapacodes4u commented Sep 21, 2025

@SlimDeluxe I had to register FrontendAdminPanel in core. Ideally this should happen automatically but for some reason its not working. But registering the panel fixed (as you said above) the frontend link not showing issue. Maybe there is a better solution for this. For now its working.

@thapacodes4u
Copy link
Contributor Author

@SlimDeluxe Now it should be fixed could you give it a try

Copy link
Member

@SlimDeluxe SlimDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check below. Otherwise ok.

@thapacodes4u
Copy link
Contributor Author

@SlimDeluxe This is ready for review

@SlimDeluxe SlimDeluxe merged commit ca912b9 into DataLinx:main Oct 21, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants