-
Notifications
You must be signed in to change notification settings - Fork 2
feat: implement product tax #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
============================================
- Coverage 38.40% 37.95% -0.45%
- Complexity 1426 1435 +9
============================================
Files 104 104
Lines 6669 6723 +54
============================================
- Hits 2561 2552 -9
- Misses 4108 4171 +63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems ok, except the fact you removed tenant isolation from the tax class resource for some reason 😄
Tax classes must remain tenant-scoped, they are not shared between tenants. Think of a multi-store project, where each site targets one country, and that country has different and unrelated tax classes (e.g VAT in Slovenia is 22%, but in Croatia it's 25%).
So please revert this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflicts in need of resolution :)
No description provided.