-
Notifications
You must be signed in to change notification settings - Fork 2
Fix / improving image lightbox #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix / improving image lightbox #28
Conversation
|
@SlimDeluxe EC-207 |
SlimDeluxe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need some changes after improving the column in the common package.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
============================================
- Coverage 32.63% 32.30% -0.33%
+ Complexity 1232 1227 -5
============================================
Files 96 96
Lines 5951 5943 -8
============================================
- Hits 1942 1920 -22
- Misses 4009 4023 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Will wait for DataLinx/eclipsephp-common#3 before review. |
|
@SlimDeluxe Should be good to review this |
|
@SlimDeluxe Let's merge this PR first DataLinx/eclipsephp-common#9 to fix the broken assets issue that you mentioned in the jira. |
|
@SlimDeluxe After that you we can review this PR |
SlimDeluxe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the conflicts here.
|
@thapacodes4u please resolve the conflicts and see about the tests failing. |
Related Ticket