Skip to content

Conversation

@thapacodes4u
Copy link
Contributor

@thapacodes4u thapacodes4u commented Sep 13, 2025

@thapacodes4u
Copy link
Contributor Author

thapacodes4u commented Sep 14, 2025

@SlimDeluxe EC-207
We need to merge this PR first then the test will pass.

Copy link
Member

@SlimDeluxe SlimDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some changes after improving the column in the common package.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 53.48837% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.30%. Comparing base (91fde85) to head (03f014e).

Files with missing lines Patch % Lines
src/Filament/Forms/Components/ImageManager.php 0.00% 13 Missing ⚠️
src/Filament/Resources/ProductResource.php 76.66% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #28      +/-   ##
============================================
- Coverage     32.63%   32.30%   -0.33%     
+ Complexity     1232     1227       -5     
============================================
  Files            96       96              
  Lines          5951     5943       -8     
============================================
- Hits           1942     1920      -22     
- Misses         4009     4023      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SlimDeluxe
Copy link
Member

Will wait for DataLinx/eclipsephp-common#3 before review.

@thapacodes4u
Copy link
Contributor Author

@SlimDeluxe Should be good to review this

@thapacodes4u
Copy link
Contributor Author

@SlimDeluxe Let's merge this PR first DataLinx/eclipsephp-common#9 to fix the broken assets issue that you mentioned in the jira.

@thapacodes4u
Copy link
Contributor Author

@SlimDeluxe After that you we can review this PR

Copy link
Member

@SlimDeluxe SlimDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts here.

@SlimDeluxe
Copy link
Member

@thapacodes4u please resolve the conflicts and see about the tests failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants