[synthetics_private_location] Migrate synthetics resource to framework #2881
+398
−578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoineDona
changed the title
synthetics_private_location to frameworksynthetics_private_location to framework
AntoineDona
changed the title
synthetics_private_location to framework
AntoineDona
force-pushed
the
antoine.donascimento/SYNTH-18766/migrate-PL-to-framework
branch
from
b69defb to
d542d75
Compare
rtrieu
previously approved these changes
Mar 3, 2025
rtrieu
previously approved these changes
Mar 5, 2025
fpighi
requested changes
Mar 7, 2025
| transfer_encoding: [] | ||
| trailer: {} | ||
| host: api.datadoghq.com | ||
| remote_addr: "" | ||
| request_uri: "" | ||
| body: | | ||
| {"description":"a private location","name":"tf-TestAccDatadogSyntheticsPrivateLocation_Basic-local-1714765065","tags":["foo:bar","baz"]} | ||
| {"description":"a private location","metadata":{},"name":"tf-TestAccDatadogSyntheticsPrivateLocation_Basic-local-1741182374","tags":["foo:bar","baz"]} |
There was a problem hiding this comment.
Since there's a bug fix here, I suggest you either:
- Split the PR so the bug fix is done in isolation (better)
- Mark this PR as a bugfix (slightly worse because it makes it harder to read what the bug fix exactly is)
There was a problem hiding this comment.
Ok, I see! As I don't want to fix it in the older sdkv2 resource and again in the new one, I will just undo the fix in this one, and create a fix pr afterwards!
There was a problem hiding this comment.
Thanks, this will help maintaining a clean commit history and changelog.
teodor2312
previously approved these changes
Mar 7, 2025
datadog/fwprovider/resource_datadog_synthetics_private_location.go
Outdated
Show resolved
Hide resolved
AntoineDona
commented
Mar 7, 2025
|
|
||
| if _, httpresp, err := apiInstances.GetSyntheticsApiV1().GetPrivateLocation(auth, r.Primary.ID); err != nil { | ||
| func SyntheticsPrivateLocationDestroyerHelper(auth context.Context, s *terraform.State, apiInstances *utils.ApiInstances) error { |
There was a problem hiding this comment.
For reviewers: added this retry feature, as every migrated resources (see example) seem to be using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the
synthetics_private_locationresource to the new terraform framework.It also fixes a bug wheremetadatawas not removable.