Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_shared_dashboard] New resource #2838

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ecdatadog
Copy link
Contributor

@ecdatadog ecdatadog commented Feb 17, 2025

resolves #876

Change compared to OpenAPI schema :

  • created_at field is not transmitted as the body response has field created with the openAPI spec says created_at
  • author structure is split in 2 fields author_handle and author_name : it is linked to a limitation at terraform level of SingleNestedBlock with only Computed field (limit of using v5 provider with framework lib)

@ecdatadog ecdatadog requested a review from a team February 17, 2025 15:26
@ecdatadog ecdatadog marked this pull request as ready for review February 17, 2025 16:29
@ecdatadog ecdatadog requested review from a team as code owners February 17, 2025 16:29
PublicUrl types.String `tfsdk:"public_url"`
ShareType types.String `tfsdk:"share_type"`
Token types.String `tfsdk:"token"`
ShareList types.List `tfsdk:"share_list"`
Copy link

@michlee1337 michlee1337 Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! This field will be marked deprecated soon sorry. We're in the process of updating the API contract for this API.

it might be worth holding off on the terraform resource for a week or so until we get the API docs updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support Public Dashboard URLs
3 participants