[data_source_datadog_software_catalog] Adding Software Catalog data source #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhgilbert
previously approved these changes
Feb 10, 2025
|
@DataDog/web-frameworks Hi, can I have a review on this please? thanks |
cmcmacs
force-pushed
the
software_catalog_entities
branch
from
42ba3f6 to
bd2d590
Compare
fpighi
reviewed
Mar 7, 2025
| optionalParams.WithPageOffset(offset) | ||
| optionalParams.WithPageLimit(limit) | ||
|
|
||
| ddResp, _, err := d.Api.ListCatalogEntity(d.Auth, *optionalParams) |
There was a problem hiding this comment.
We'll need to check if the ordering of entities from the API is stable. If not, could we do something to make it stable in the provider code (e.g. order by name). This way we minimize chances of meaningless drifts in plans.
There was a problem hiding this comment.
This API endpoint doesnt support ordering, I added sort.Slice to explicitly sort slice before setting it to state in func (d *datadogSoftwareCatalogDataSource) updateState
kguske-datadog
previously approved these changes
Mar 7, 2025
fpighi
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Software Catalog data source, using V2 api for getting Catalog Entities.