Skip to content

Enables .NET OTEL Metrics Tests #5535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 24, 2025
Merged

Enables .NET OTEL Metrics Tests #5535

merged 14 commits into from
Nov 24, 2025

Conversation

@link04
Copy link
Contributor

@link04 link04 commented Oct 16, 2025

Motivation

Enabling tests to validate support for OTLP Metrics in both Grpc and Http format for the .NET tracer.

Changes

Added a couple of endpoints needed so the tests could pass and update test to validate for AsInt which .NET uses for long values.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2025

CODEOWNERS have been resolved as:

manifests/dotnet.yml                                                    @DataDog/apm-dotnet @DataDog/asm-dotnet
tests/parametric/test_otel_metrics.py                                   @DataDog/system-tests-core @DataDog/apm-sdk-capabilities
utils/build/docker/dotnet/parametric/Endpoints/ApmTestApiOtel.cs        @DataDog/apm-dotnet @DataDog/asm-dotnet @DataDog/system-tests-core

@link04 link04 changed the title [dotnet@maximo/otel-metrics-grpc-support] Enables Parametric OTEL Metrics Tests [dotnet@maximo/otel-metrics-grpc-support] Enables .NET OTEL Metrics Tests Oct 16, 2025
@link04 link04 changed the title [dotnet@maximo/otel-metrics-grpc-support] Enables .NET OTEL Metrics Tests Enables .NET OTEL Metrics Tests Oct 17, 2025
link04 and others added 8 commits October 17, 2025 16:22
@link04
Removing Old tests cases
e35814d
@zacharycmontoya
Fix flush operation to lookup the correct type via reflection
dbbe01b
@zacharycmontoya
Skip schema_url assertion for the .NET library, since .NET doesn't ex…
1c6371f 
…pose this in the Metrics API and OTLP
@zacharycmontoya
Update Test_Otel_Metrics_Telemetry::test_telemetry_default_configurat…
00eed20 
…ions to loosen assertion on configuration telemetry to only assert against key OTEL_EXPORTER_OTLP_METRICS_TIMEOUT, no longer requiring key OTEL_EXPORTER_OTLP_TIMEOUT
@zacharycmontoya
Update .NET manifest file to use the version which shipped full suppo…
9416829 
…rt of OTLP metrics, v3.29.0
@zacharycmontoya
Remove test skips for .NET library. The only xfailed tests now are:
9940e1c 
- Test_Otel_Metrics_Host_Name::test_hostname_from_dd_hostname
- Test_Otel_Metrics_Telemetry::test_telemetry_metrics_http_protobuf
- Test_Otel_Metrics_Telemetry::test_telemetry_metrics_grpc
@zacharycmontoya
Merge branch 'main' into maximo/enables-otel-metrics-tests
2ce5a73
@zacharycmontoya
Fix Python formatting and typing after merge
0d66569
@zacharycmontoya zacharycmontoya marked this pull request as ready for review November 19, 2025 00:41
@zacharycmontoya zacharycmontoya requested review from a team as code owners November 19, 2025 00:41
@zacharycmontoya zacharycmontoya requested review from genesor and removed request for a team November 19, 2025 00:41
cbeauchesne
cbeauchesne requested changes Nov 19, 2025
View reviewed changes
@cbeauchesne
Copy link
Collaborator

cbeauchesne commented Nov 20, 2025

Rebasing to fix the C++ issue

@zacharycmontoya zacharycmontoya merged commit ddbab50 into main Nov 24, 2025
803 of 805 checks passed
@zacharycmontoya zacharycmontoya deleted the maximo/enables-otel-metrics-tests branch November 24, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zacharycmontoya zacharycmontoya zacharycmontoya left review comments

@cbeauchesne cbeauchesne cbeauchesne approved these changes

@genesor genesor Awaiting requested review from genesor genesor is a code owner automatically assigned from DataDog/apm-sdk-capabilities

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@link04 @cbeauchesne @zacharycmontoya