Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change endpoint fingerprint query parameter to optional #365

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Jan 22, 2025

This PR changes the endpoint fingerprint to allow for a missing query parameter; this can happen when the request includes no query parameters.

Related Jira: APPSEC-56486

@Anilm3 Anilm3 requested a review from a team as a code owner January 22, 2025 20:22
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.13%. Comparing base (9d853b9) to head (2e37bd8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
- Coverage   85.13%   85.13%   -0.01%     
==========================================
  Files         157      157              
  Lines        7994     7993       -1     
  Branches     3551     3551              
==========================================
- Hits         6806     6805       -1     
  Misses        459      459              
  Partials      729      729              
Flag Coverage Δ
waf_test 85.13% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 22, 2025

Benchmarks

Benchmark execution time: 2025-01-22 20:51:41

Comparing candidate commit 2e37bd8 in PR branch anilm3/endpoint-fingerprint-query-optional with baseline commit 9d853b9 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 0 metrics, 0 unstable metrics.

scenario:global-benchmark.random

  • 🟥 execution_time [+9.268ms; +9.299ms] or [+3.206%; +3.216%]

@Anilm3 Anilm3 merged commit 73ad8e7 into master Jan 23, 2025
51 checks passed
@Anilm3 Anilm3 deleted the anilm3/endpoint-fingerprint-query-optional branch January 23, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants