Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cmake scripts and support LTO #232

Merged
merged 29 commits into from
Nov 23, 2023
Merged

Refactor cmake scripts and support LTO #232

merged 29 commits into from
Nov 23, 2023

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Nov 13, 2023

This PR builds on #231:

  • Refactor and simplify cmake scripts
  • Build LTO shared objects and non-LTO static objects when LTO enable
  • Use clang-17 instead of 15 and apply clang-format / tidy fixes
  • Remove some unused vendorised libraries
  • Fix some build warnings

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (55879e9) 83.23% compared to head (014a9dd) 83.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   83.23%   83.23%           
=======================================
  Files         106      106           
  Lines        4176     4176           
  Branches     1914     1914           
=======================================
  Hits         3476     3476           
  Misses        279      279           
  Partials      421      421           
Flag Coverage Δ
waf_test_none 83.13% <ø> (ø)
waf_test_sse2 83.20% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Anilm3 Anilm3 changed the title Anilm3/lto Refactor cmake scripts and support LTO Nov 14, 2023
@Anilm3 Anilm3 changed the base branch from master to anilm3/vendorize-remaining November 15, 2023 09:32
Base automatically changed from anilm3/vendorize-remaining to master November 16, 2023 09:02
@Anilm3 Anilm3 marked this pull request as ready for review November 16, 2023 09:25
@Anilm3 Anilm3 requested a review from a team as a code owner November 16, 2023 09:25
estringana
estringana previously approved these changes Nov 16, 2023
@Anilm3
Copy link
Collaborator Author

Anilm3 commented Nov 17, 2023

Performance tests on clang-17 after yesterday's fixes to boolean generators (non-lto baseline vs lto):

context_destroy            : 9.00% faster than baseline, (z-test: -8.71)
run.mixed                  : 5.86% faster than baseline, (z-test: -4.81)
run.random.any             : 3.33% faster than baseline, (z-test: -2.90)
run.random.deep_containers : 3.40% faster than baseline, (z-test: -3.27)
run.random.long_strings    : 1.85% faster than baseline, NOT statistically significant (z-test: -1.61)
run.valid                  : 6.25% faster than baseline, (z-test: -5.14)

estringana
estringana previously approved these changes Nov 17, 2023
@Anilm3 Anilm3 requested a review from cataphract November 20, 2023 16:40
@Anilm3 Anilm3 merged commit 80e31fd into master Nov 23, 2023
@Anilm3 Anilm3 deleted the anilm3/lto branch November 23, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants