Typingdna ActiveLock - new dashboard, version 3.0 (ECOINT-86) #2585
+967
−875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New dashboard update. Only the dashboard is different, no other change.
Update the dashboard jpg for manifest, and changelog.md update to support the new dashboard update.
Date format fixed
Fixed changelog type
|
Just a minor update for the main dashboard as we added a new main action: lock. |
urseberry
reviewed
Jan 21, 2025
typingdna_activelock/assets/dashboards/TypingDNAActiveLock.json
Outdated
Show resolved
Hide resolved
urseberry
approved these changes
Jan 21, 2025
dd-dominic
requested changes
Jan 23, 2025
typingdna_activelock/assets/dashboards/TypingDNAActiveLock.json
Outdated
Show resolved
Hide resolved
typingdna_activelock/assets/dashboards/TypingDNAActiveLock.json
Outdated
Show resolved
Hide resolved
Requested updates for dashboard look and json format.
size was too large
Co-authored-by: Dominic Medina <[email protected]>
added details..
|
@raulpopa one more item - please update the manifest file to include "Submitted Data Type::Logs". This is presented in the tile and helps users understand what type of data is submitted. See example here: https://github.com/DataDog/integrations-extras/blob/master/modal/manifest.json#L34 |
|
@dd-dominic is there anything else you need from me? |
dd-dominic
changed the title
dd-dominic
requested changes
Jan 29, 2025
temporal-github-worker-1
bot
added
product/requested-changes
and removed
product/review-requested
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
New update for the main dashboard as we added a new main action: lock.
Motivation
New update for the main dashboard as we added a new main action: lock.
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?