-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix MongoDB integration containerized environment links #21981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The relative links for containerized environment sections (Docker, Kubernetes, ECS) were using the format ?tab=xxx#xxx which doesn't retain the MongoDB context on the published docs site. Changed: - ?tab=docker#docker -> #docker - ?tab=kubernetes#kubernetes -> #kubernetes - ?tab=ecs#ecs -> #ecs Fixes DataDog#21952
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
|
@saikumarvasa100-hash Sorry, I previously reviewed this and then did a bit more testing! Left a comment with the behavior I'm seeing. I'm not sure if this is what you're intending. |
Use ?tab= query parameter along with anchor links to ensure links work correctly when switching between Docker, Kubernetes, and ECS tabs.
saikumarvasa100-hash
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the asked changes were done check again
|
@saikumarvasa100-hash / @domalessi This PR made me wonder if "Configuration" might be the intended parent tab for these links, but after taking a closer look I realized there is nothing wrong with how the links were formatted. The sections they used to point to were replaced by tabbed examples in the docs. Since the in-app integration view does not support subsection anchors the way the docs site does, the links no longer have a valid target and send users back to the Integrations landing page. I saw the same pattern in a couple of other integrations, so I opened #22011 to remove the outdated links. Thanks for your time! |
|
@domalessi - Yes, #22011 handles the fixes. Good to close this PR. Thanks for taking a look. |
The relative links for containerized environment sections (Docker, Kubernetes, ECS) were using the format ?tab=xxx#xxx which doesn't retain the MongoDB context on the published docs site.
Changed:
Fixes #21952
What does this PR do?
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged