Skip to content

Conversation

jszwedko
Copy link
Contributor

@jszwedko jszwedko commented Oct 1, 2025

What does this PR do?

Correct description of disable_missing_mountpoints_warning, if the value is true then the warning is suppressed.

Motivation

Customer reported incorrect description.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

If the value is _true_ then the warning is suppressed.
Signed-off-by: Jesse Szwedko <[email protected]>
Copy link

github-actions bot commented Oct 1, 2025

⚠️ Recommendation: Add qa/skip-qa Label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

@jszwedko jszwedko added the qa/skip-qa Automatically skip this PR for the next QA label Oct 1, 2025
@buraizu
Copy link
Contributor

buraizu commented Oct 1, 2025

Hi @jszwedko, it looks like d5f35ec reverted the initial change and there's no longer anything to review.

@buraizu buraizu self-assigned this Oct 1, 2025
@buraizu buraizu added the editorial review Waiting on a more in-depth review from a docs team editor label Oct 1, 2025
Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko
Copy link
Contributor Author

jszwedko commented Oct 2, 2025

Hi @jszwedko, it looks like d5f35ec reverted the initial change and there's no longer anything to review.

Doh! Thanks for catching that. I see I updated the wrong file initially. It should be ready now.

Copy link

github-actions bot commented Oct 2, 2025

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and
the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent
nfsstat/datadog_checks/nfsstat/data/conf.yaml.example

Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.00%. Comparing base (32e0fdf) to head (1e3eb31).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jszwedko jszwedko added this pull request to the merge queue Oct 2, 2025
Merged via the queue into master with commit fdb4e45 Oct 2, 2025
53 of 56 checks passed
@jszwedko jszwedko deleted the jszwedko/correct-description-disable_missing_mountpoints_warning branch October 2, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants