Skip to content

[DBM] [SQL Server] Hides the query_activity.collection_interval option to prevent misuse #20134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aldrickdev
Copy link
Contributor

@aldrickdev aldrickdev commented Apr 23, 2025

What does this PR do?

This PR will just hid the query_activity.collection_interval option in the conf.yaml to prevent misuse.

Motivation

DBMON-5019

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@aldrickdev aldrickdev added changelog/no-changelog qa/skip-qa Automatically skip this PR for the next QA labels Apr 23, 2025
@aldrickdev aldrickdev requested review from a team as code owners April 23, 2025 13:48
@aldrickdev aldrickdev changed the title Hides the query_activity.collection_interval option to prevent misuse [DBM] [SQL Server] Hides the query_activity.collection_interval option to prevent misuse Apr 23, 2025
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.86%. Comparing base (8e8a37a) to head (d5f11d5).
Report is 1 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
sqlserver 91.46% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant