[AI-5206] DDS: WatchGuard Firebox Integration v1.0.0#20030
Merged
NouemanKHAL merged 16 commits intoDataDog:masterfrom May 21, 2025
Merged
[AI-5206] DDS: WatchGuard Firebox Integration v1.0.0#20030NouemanKHAL merged 16 commits intoDataDog:masterfrom
NouemanKHAL merged 16 commits intoDataDog:masterfrom
Conversation
datadog-agent-integrations-bot
Bot
added
documentation
dev/testing
dev/tooling
release
qa/skip-qa
manan-crest
changed the title
buraizu
added
the
editorial review
Contributor
|
Created DOCS-10585 for documentation team review |
temporal-github-worker-1
Bot
dismissed
NouemanKHAL’s stale review
Review from NouemanKHAL is dismissed. Related teams and files:
- agent-integrations
- .github/workflows/config/labeler.yml
temporal-github-worker-1
Bot
added
agent/review-requested
and removed
agent/approved
labels
jnhunsberger
requested changes
May 16, 2025
jnhunsberger
left a comment
jnhunsberger
left a comment
There was a problem hiding this comment.
A couple changes needed. See comments.
|
|
||
| This integration enriches and ingests the following events: | ||
|
|
||
| - **Firewall Events**: Represents log messages generated by your Firebox for events that occur on the Firebox and for traffic managed by some packet filter policies. In addition to normal traffic, this can include messages related to feature keys, subscription services, server load balancing, and other features configured on your Firebox. |
There was a problem hiding this comment.
Copy update: strike some from by some packet filter policies
Also what are feature keys?
Contributor
There was a problem hiding this comment.
- Removed
somefromby some packet filter policies. - A
feature keyenables a set of licensed features on your Firebox.
There was a problem hiding this comment.
Can we have a better image? This image looks squished and distorted.
Contributor
There was a problem hiding this comment.
Sure, We have updated all images.
temporal-github-worker-1
Bot
dismissed
jhgilbert’s stale review
Review from jhgilbert is dismissed. Related teams and files:
- documentation
- watchguard_firebox/README.md
temporal-github-worker-1
Bot
added
docs/review-requested
and removed
docs/approved
labels
Contributor
Hi @jnhunsberger, We have done all changes. |
NouemanKHAL
approved these changes
May 19, 2025
temporal-github-worker-1
Bot
added
agent/approved
and removed
agent/review-requested
labels
jhgilbert
approved these changes
May 19, 2025
temporal-github-worker-1
Bot
added
docs/approved
and removed
docs/review-requested
labels
ieguinoa
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR for a new integration WatchGuard Integration 1.0.0
Additional Notes
-- OOTB detection rules JSON would be shared separately with the required teams as a part of separate repository .
-- Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current datadog behavior.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged