[feat] redisdb: Adds replication byte metrics #20029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valdisrigdon
force-pushed
the
redis-more-metrics
branch
3 times, most recently
from
c2df98b to
178bd3c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
valdisrigdon
force-pushed
the
redis-more-metrics
branch
3 times, most recently
from
18c9a44 to
aaa54c1
Compare
valdisrigdon
force-pushed
the
redis-more-metrics
branch
from
aaa54c1 to
49aa2c2
Compare
dkirov-dd
approved these changes
Apr 29, 2025
There was a problem hiding this comment.
Hello @valdisrigdon, thank you for your contribution!
Approved 👍
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/review-requested
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds two new metrics for replication byte counts to the redisdb integration.
Motivation
The prometheus exporter has these metrics oliver006/redis_exporter#951
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged