FIPS compliant v3.5.17-dd.3 build
#10
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,18 +8,69 @@ on: | |
| - "*-dd*" | ||
| permissions: write-all | ||
| jobs: | ||
| build-amd64: | ||
| strategy: | ||
| matrix: | ||
| platform: ["linux/amd64"] | ||
| runs-on: ubuntu-24.04 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| - name: Set environment variables | ||
| id: set_env | ||
| run: | | ||
| echo "RELEASE_VERSION=${GITHUB_REF#refs/tags/}" >> $GITHUB_ENV | ||
| echo "TARGET_OS=$(echo ${{ matrix.platform }} | cut -d'/' -f1)" >> $GITHUB_ENV | ||
| echo "TARGET_ARCH=$(echo ${{ matrix.platform }} | cut -d'/' -f2)" >> $GITHUB_ENV | ||
| env: | ||
| GITHUB_REF: ${{ github.ref }} | ||
| - name: Build etcd | ||
| run: | | ||
| REPOSITORY=https://github.com/${{ env.GITHUB_REPOSITORY }}.git \ | ||
| CGO_ENABLED=1 \ | ||
| GOEXPERIMENT=boringcrypto \ | ||
| GO_BUILD_FLAGS="-tags=fips" \ | ||
| TARGET_OS=${TARGET_OS} \ | ||
| TARGET_ARCH=${TARGET_ARCH} \ | ||
| ./scripts/build-binary-single-target ${{ env.RELEASE_VERSION }} | ||
| env: | ||
| GITHUB_REPOSITORY: ${{ github.repository }} | ||
| - name: Calculate checksums | ||
| id: calculate_checksums | ||
| shell: bash | ||
| working-directory: release/ | ||
| run: ls . | grep -E '\.tar.gz$|\.zip$' | xargs shasum -a 256 > ./SHA256SUMS | ||
| - uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: etcd_output_amd64 | ||
| path: release/ | ||
| build-arm64: | ||
| strategy: | ||
| matrix: | ||
| platform: ["linux/arm64"] | ||
| runs-on: ubuntu-24.04-arm | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
There was a problem hiding this comment. 🟠 Code VulnerabilityWorkflow depends on a GitHub actions pinned by tag instead of a hash. (...read more)Pin GitHub Actions by commit hash to ensure supply chain security. Using a branch ( - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
|
||
| with: | ||
| fetch-depth: 0 | ||
| - name: Set environment variables | ||
| id: set_env | ||
| run: | | ||
| echo "RELEASE_VERSION=${GITHUB_REF#refs/tags/}" >> $GITHUB_ENV | ||
| echo "TARGET_OS=$(echo ${{ matrix.platform }} | cut -d'/' -f1)" >> $GITHUB_ENV | ||
| echo "TARGET_ARCH=$(echo ${{ matrix.platform }} | cut -d'/' -f2)" >> $GITHUB_ENV | ||
| env: | ||
| GITHUB_REF: ${{ github.ref }} | ||
| - name: Build etcd | ||
| run: | | ||
| REPOSITORY=https://github.com/${{ env.GITHUB_REPOSITORY }}.git \ | ||
| CGO_ENABLED=1 \ | ||
| GOEXPERIMENT=boringcrypto \ | ||
| GO_BUILD_FLAGS="-tags=fips" \ | ||
| TARGET_OS=${TARGET_OS} \ | ||
| TARGET_ARCH=${TARGET_ARCH} \ | ||
| ./scripts/build-binary-single-target ${{ env.RELEASE_VERSION }} | ||
| env: | ||
| GITHUB_REPOSITORY: ${{ github.repository }} | ||
| - name: Calculate checksums | ||
|
|
@@ -29,13 +80,13 @@ jobs: | |
| run: ls . | grep -E '\.tar.gz$|\.zip$' | xargs shasum -a 256 > ./SHA256SUMS | ||
| - uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: etcd_output_arm64 | ||
| path: release/ | ||
| release: | ||
| permissions: | ||
| contents: write | ||
| runs-on: ubuntu-latest | ||
| needs: [build-amd64, build-arm64] | ||
| outputs: | ||
| upload_url: ${{ steps.create_release_branch.outputs.upload_url }}${{ steps.create_release_tags.outputs.upload_url }} | ||
| steps: | ||
|
|
@@ -78,26 +129,32 @@ jobs: | |
| release_name: ${{ steps.extract_tags.outputs.tags }} | ||
| draft: false | ||
| prerelease: false | ||
| releaseassets: | ||
| runs-on: ubuntu-latest | ||
| needs: release | ||
| strategy: | ||
| matrix: | ||
| platform: ["linux-arm64","linux-amd64"] | ||
| extension: ["tar.gz"] | ||
| steps: | ||
| - name: Set artifact name | ||
| id: set_artifact | ||
| run: | | ||
| if [[ "${{ matrix.platform }}" == *"arm64"* ]]; then | ||
| echo "ARTIFACT_NAME=etcd_output_arm64" >> $GITHUB_ENV | ||
| else | ||
| echo "ARTIFACT_NAME=etcd_output_amd64" >> $GITHUB_ENV | ||
| fi | ||
| - name: Download artifacts | ||
| uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8 | ||
| with: | ||
| name: ${{ env.ARTIFACT_NAME }} | ||
| path: _output/release-tars | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| - name: Set release version environment variable | ||
| run: echo RELEASE_VERSION=${GITHUB_REF#refs/tags/} >> $GITHUB_ENV | ||
| env: | ||
| GITHUB_REF: ${{ github.ref }} | ||
| - name: Upload Release Asset | ||
| id: upload-release-asset | ||
| uses: actions/upload-release-asset@v1 | ||
|
|
@@ -112,11 +169,16 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| needs: release | ||
| steps: | ||
| - name: Create output directory | ||
| run: mkdir -p _output/checksums | ||
| - name: Download all artifacts | ||
| uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8 | ||
| with: | ||
| path: _output/artifacts | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| - name: Combine checksums | ||
| run: | | ||
| find _output/artifacts -name "SHA256SUMS" -exec cat {} \; > _output/checksums/SHA256SUMS | ||
| - name: Upload checksums | ||
| id: upload-checksums | ||
| uses: actions/upload-release-asset@v1 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 1.23.7 | ||
|
badouralix marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| module go.etcd.io/etcd/api/v3 | ||
|
|
||
| go 1.23 | ||
|
|
||
| toolchain go1.23.7 | ||
|
|
||
| require ( | ||
| github.com/coreos/go-semver v0.3.0 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| //go:build fips | ||
|
|
||
| package main | ||
|
|
||
| // enforce fips compliance if boringcrypto is enabled | ||
| import _ "crypto/tls/fipsonly" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| //go:build fips | ||
|
|
||
| package main | ||
|
|
||
| // enforce fips compliance if boringcrypto is enabled | ||
| import _ "crypto/tls/fipsonly" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag instead of a hash. (...read more)
Pin GitHub Actions by commit hash to ensure supply chain security.
Using a branch (
@main) or tag (@v1) allows for implicit updates, which can introduce unexpected or malicious changes. Instead, always pin actions to a full length commit SHA. You can find the commit SHA for the latest tag from the action’s repository and ensure frequent updates via auto-updaters such as dependabot. Include a comment with the corresponding full-length SemVer tag for clarity: