-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Clarify remapper processor #33577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify remapper processor #33577
Conversation
Preview links (active after the
|
8d58560 to
3875c9c
Compare
buraizu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with some minor suggestions
| The remapper processor remaps one or more source attribute(s) or tags to different target attribute or tag. For example, you can remap the `user` attribute to `firstname` to normalize log data in the Log Explorer. | ||
|
|
||
| Constraints on the tag/attribute name are explained in the [attributes and tags documentation][5]. Some additional constraints, applied as `:` or `,`, are not allowed in the target tag/attribute name. | ||
| If the remapper target is an attribute, the processor can also try to cast the value to a new type (`String`, `Integer` or `Double`). If the cast fails, the original value and type are preserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| If the remapper target is an attribute, the processor can also try to cast the value to a new type (`String`, `Integer` or `Double`). If the cast fails, the original value and type are preserved. | |
| If the remapper target is an attribute, the processor can also try to cast the value to a new type (`String`, `Integer`, or `Double`). If the cast fails, the original value and type are preserved. |
| If the remapper target is an attribute, the processor can also try to cast the value to a new type (`String`, `Integer` or `Double`). If the cast fails, the original value and type are preserved. | ||
|
|
||
| If the target of the remapper is an attribute, the remapper can also try to cast the value to a new type (`String`, `Integer` or `Double`). If the cast is not possible, the original type is kept. | ||
| **Note**: The decimal separator for `Double` values need to be `.`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| **Note**: The decimal separator for `Double` values need to be `.`. | |
| **Note**: The decimal separator for `Double` values must be `.`. |
| **Note**: The decimal separator for `Double` need to be `.`. | ||
| ### Naming constraints | ||
|
|
||
| Characters `:` and `,`, are not allowed in the target attribute or tag names. Additionally, tag and attribute names must follow the conventions outlined in [Attributes and Aliasing][5]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Characters `:` and `,`, are not allowed in the target attribute or tag names. Additionally, tag and attribute names must follow the conventions outlined in [Attributes and Aliasing][5]. | |
| Characters `:` and `,` are not allowed in the target attribute or tag names. Additionally, tag and attribute names must follow the conventions outlined in [Attributes and Aliasing][5]. |
What does this PR do? What is the motivation?
Merge instructions
Merge readiness: