fix: update feature flag node.js docs to properly set context #33571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greghuels
requested review from
dd-oleksii,
leoromanovsky,
sameerank and
typotter
Contributor
Preview links (active after the
|
dd-oleksii
approved these changes
Dec 24, 2025
Member
dd-oleksii
left a comment
dd-oleksii
left a comment
There was a problem hiding this comment.
The change looks good. However it looks like targeting key is missing, so the sharding will not work properly and I believe that's not intended
Comment on lines
76
to
79
| const evaluationContext = { | ||
| userID: req.session?.userID, | ||
| companyID: req.session?.companyID | ||
| }); | ||
| }; |
Member
There was a problem hiding this comment.
shall we set targetingKey here?
Contributor
Author
There was a problem hiding this comment.
Yeah, we definitely should. I'll use userID as the targeting key
evazorro
approved these changes
Dec 24, 2025
Contributor
evazorro
left a comment
evazorro
left a comment
There was a problem hiding this comment.
I'll let other reviewers comment on the technical accuracy, but this looks good from a Markdown formatting perspective so I'm approving! Let me know if you need a re-approval after applying others' suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
The Node.js docs for OpenFeature suggested using
OpenFeature.setContextto set user-specified attributes. This is not a good practice for server SDKs since it leads to race conditions. Examples in the docs have been updated to evaluation-specific context.Merge instructions
Merge readiness: