-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New doc for service override removal #33535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| | With service overrides | `service:my-service-mysql` or `service:mysql` | None | | ||
| | Without service overrides | `service:myservice` | `@peer.db.name:user-db`, `@peer.db.system:mysql` | | ||
|
|
||
| ## Remove overrides progressively |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marianafrangos I pulled this content over from the Service Overrides Guide.
- Is this still the recommended flow for removing service overrides, whether you do it in the UI or through config/env var setting? Or does it apply only to env var setting?
- Are any of these steps essentially overridden by the new UI functionality? For example, I know the UI will show affected dashboards, so you don't have to dig around to find that yourself. Do we want to direct folks to the new UI features for some of these steps, even if they're going the env var route?
Preview links (active after the
|
drichards-87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. I just left one comment and a suggestion. PR is approved.
Co-authored-by: DeForest Richards <[email protected]>
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes