-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Session Replay reorg #33472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Session Replay reorg #33472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Almost all my comments are non-blocking edit suggestions, but I did find a broken link to resolve.
I also noted some discrepancy with terms like Click map vs. Clickmap, which might be a bit out of scope for a reorg PR like this, but I figured I'd note it just for awareness.
| {{< tabs >}} | ||
| {{% tab "RUM" %}} | ||
|
|
||
| Use the [RUM Analytics explorer][1] to explore and analyze your user data. | ||
|
|
||
| [1]: /real_user_monitoring/explorer/ | ||
|
|
||
| {{% /tab %}} | ||
| {{% tab "Product Analytics" %}} | ||
|
|
||
| Use the [Product Analytics explorer][1] to explore and analyze your user data. | ||
|
|
||
| [1]: /product_analytics/charts/analytics_explorer/ | ||
|
|
||
| {{% /tab %}} | ||
| {{< /tabs >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, tabs seem like more structure than needed for this short amount of text. But feel free to ignore if there are other considerations for using them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i agree, it feels like overkill, but there are significant enough changes that i needed some way to distinguish them. this will probably be solved with cdocs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks for considering. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, decided to remove the tabs but just left them for the nav part of it (earlier around line 44).
Co-authored-by: Joe Peeples <[email protected]>
joepeeples
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One follow-up suggestion on the tabs > bullet change, but everything LGTM!
| After analyzing heatmaps, the next step is to understand the user action by exploring related data. Watch associated [session replays][1] to see user actions in the context of their overall session, or navigate to an Analytics explorer: | ||
|
|
||
| - **RUM**: Use the [RUM Analytics explorer][3] to explore and analyze your user data. | ||
| - **Product Analytics**: Use the [Product Analytics explorer][4] to explore and analyze your user data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might not even need a bulleted list, because the content is nearly identical ("explore and analyze your user data"), and the explorer names themselves are very clear:
| After analyzing heatmaps, the next step is to understand the user action by exploring related data. Watch associated [session replays][1] to see user actions in the context of their overall session, or navigate to an Analytics explorer: | |
| - **RUM**: Use the [RUM Analytics explorer][3] to explore and analyze your user data. | |
| - **Product Analytics**: Use the [Product Analytics explorer][4] to explore and analyze your user data. | |
| After analyzing heatmaps, the next step is to understand the user action by exploring related data. Watch associated [session replays][1] to see user actions in the context of their overall session, or navigate to the [RUM Analytics explorer][3] or [Product Analytics explorer][4] to explore and analyze your user data. |
That's a pretty chonky sentence now, so maybe we could break it up or something, but in general this info might work as regular text.
What does this PR do? What is the motivation?
Session Replay is now an add-on for RUM and PA, so the docs need to be standalone.
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes