-
Notifications
You must be signed in to change notification settings - Fork 1.2k
add react & js docs for feature flag setup #33281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Preview links (active after the
|
|
Created DOCS-12884 for documentation team review |
nothing wrong with these, but they are distracting in the diff
joepeeples
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple comments to consider, thanks! This PR also seems to overlap with the "browser" SDK documented in #33445, but we can discuss that separately.
|
|
||
| ## Evaluate flags | ||
|
|
||
| Once the provider is initialized, you can evaluate flags anywhere in your application. Flag evaluation is _local and instantaneous_ - the SDK uses locally cached data, so no network requests occur when evaluating flags. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Once the provider is initialized, you can evaluate flags anywhere in your application. Flag evaluation is _local and instantaneous_ - the SDK uses locally cached data, so no network requests occur when evaluating flags. | |
| After the provider is initialized, you can evaluate flags anywhere in your application. Flag evaluation is _local and instantaneous_—the SDK uses locally cached data, so no network requests occur when evaluating flags. |
| } | ||
| {{< /code-block >}} | ||
|
|
||
| ## Updating the evaluation context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, WDYT about moving this section to immediately follow "Set the evaluation context" since they seem related? It feels a little tacked onto the end of the page here.
| ## Updating the evaluation context | |
| ## Update the evaluation context |
| } | ||
| {{< /code-block >}} | ||
|
|
||
| ## Updating the evaluation context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as comment above, consider moving this section to immediately follow "Set the evaluation context" since they seem related?
| ## Updating the evaluation context | |
| ## Update the evaluation context |
correct alt text in JavaScript tile in partial Co-authored-by: StefonSimmons <[email protected]>
What does this PR do? What is the motivation?
Adds setup instructions for feature flags JavaScript & React SDKs.
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes