Skip to content

Conversation

@patrickywl
Copy link
Contributor

What does this PR do? What is the motivation?

This PR introduces MSP-specific AWS Cloud Cost Management setup documentation under the Partners section.

For background and full context, see the following documents:

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@patrickywl patrickywl requested a review from a team as a code owner December 10, 2025 04:32
@github-actions github-actions bot added Architecture Everything related to the Doc backend Images Images are added/removed with this PR labels Dec 10, 2025
@github-actions
Copy link
Contributor

@joepeeples
Copy link
Contributor

joepeeples commented Dec 10, 2025

Opened DOCS-12876 to assign a Docs writer and follow up with editorial review.

@joepeeples joepeeples added the editorial review Waiting on a more in-depth review label Dec 10, 2025
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @patrickywl, I've left a ton of feedback but it's mostly around formatting. Thanks so much for this PR! Aside from my suggestions, some general notes:

  • lots of terms such as member account should be in lowercase unless they are product/feature names
  • I think all the content under line 139 (Configure the Cost and Usage Report settings in Datadog) can be consolidated into one step. for ex:
    • Screenshot 2025-12-19 at 12 16 04 PM
    • Screenshot 2025-12-19 at 12 16 09 PM
  • the last image doesn't show the "Activate now button" (but the previous one does), so not sure what we're trying to show there. i would remove it.

happy to work with you on this further!

text: "Understand your Kubernetes and ECS spend with Datadog Cloud Cost Management"
- link: "https://www.datadoghq.com/blog/google-cloud-cost-management/"
tag: "Blog"
text: "Empower engineers to take ownership of Google Cloud costs with Datadog"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this relevant?

- link: "https://www.datadoghq.com/blog/cloud-cost-management-saved-millions/"
tag: "Blog"
text: "How we saved $1.5 million per year with Cloud Cost Management"
- link: "https://www.datadoghq.com/blog/cloud-cost-management-oci/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this relevant?


[1]: /cloud_cost_management/setup/aws/
[2]: /cloud_cost_management/setup/aws/?tab=manual#prerequisite-generate-a-cost-and-usage-report
[3]: /getting_started/integrations/aws/#setup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[3]: /getting_started/integrations/aws/#setup

[1]: /cloud_cost_management/setup/aws/
[2]: /cloud_cost_management/setup/aws/?tab=manual#prerequisite-generate-a-cost-and-usage-report
[3]: /getting_started/integrations/aws/#setup
[4]: https://app.datadoghq.com/cost/settings/accounts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[4]: https://app.datadoghq.com/cost/settings/accounts

[2]: /cloud_cost_management/setup/aws/?tab=manual#prerequisite-generate-a-cost-and-usage-report
[3]: /getting_started/integrations/aws/#setup
[4]: https://app.datadoghq.com/cost/settings/accounts
[11]: https://docs.aws.amazon.com/billingconductor/latest/userguide/what-is-billingconductor.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[11]: https://docs.aws.amazon.com/billingconductor/latest/userguide/what-is-billingconductor.html

[3]: /getting_started/integrations/aws/#setup
[4]: https://app.datadoghq.com/cost/settings/accounts
[11]: https://docs.aws.amazon.com/billingconductor/latest/userguide/what-is-billingconductor.html
[12]: https://docs.aws.amazon.com/cur/latest/userguide/cur-data-view.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[12]: https://docs.aws.amazon.com/cur/latest/userguide/cur-data-view.html

[4]: https://app.datadoghq.com/cost/settings/accounts
[11]: https://docs.aws.amazon.com/billingconductor/latest/userguide/what-is-billingconductor.html
[12]: https://docs.aws.amazon.com/cur/latest/userguide/cur-data-view.html
[13]: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cfn-console-create-stack.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[13]: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cfn-console-create-stack.html

@patrickywl
Copy link
Contributor Author

Hi @rtrieu, thank you so much for the thorough and detailed review. I agree with your suggestions.
I will make another commit incorporating your feedback and share it with you for a follow-up review.

patrickywl and others added 2 commits December 26, 2025 11:21
Applying Rosa's suggestions

Co-authored-by: Rosa Trieu <[email protected]>
@patrickywl
Copy link
Contributor Author

Hi @rtrieu, I have updates based on your feedback. Here’s a quick summary of what I changed:

• For further reading
Removed links that felt less relevant to keep the section focused.

• For "lots of terms such as member account should be in lowercase unless they are product/feature names" and not product/feature names
Updated terms like member account and pro forma to lowercase where they are not product or feature names, per your suggestion.

• For "it feels like the headers here are too big for a short checklist."
I shortened and simplified the checklist-style sections based on your recommendation.
Please let me know if you think a different structure would work better.

• For "missing a lot of context here. how about something like this:"
Agreed with your comment here and added more explanation to clarify the flow and intent.

• For "this appears to be duplicate information from the previous section"
Step 3 is performed in AWS, while Step 4-2 is performed in Datadog.
I kept both explicitly to avoid confusion about where each action happens, but happy to revise if you think this can be expressed more cleanly.

Let me know if you’d like me to adjust anything further.

@patrickywl patrickywl requested a review from rtrieu December 26, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review Images Images are added/removed with this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants