Skip to content

Update docs structure for Dynamic Instrumentation #29892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 13, 2025

Conversation

domalessi
Copy link
Contributor

@domalessi domalessi commented Jun 11, 2025

What does this PR do? What is the motivation?

The DI docs live under APM (/tracing) but the URLs don't reflect that. I moved the DI content folder to live under the tracing folder and updated all URLs to reflect the correct hierarchy.
https://datadoghq.atlassian.net/browse/DOCS-10698

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@domalessi domalessi requested review from a team as code owners June 11, 2025 20:34
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Jun 11, 2025
Copy link
Contributor

github-actions bot commented Jun 11, 2025

✅ Documentation Team Review

The documentation team has approved this pull request. Thank you for your contribution!

Copy link
Contributor

Preview links (active after the build_preview check completes)

Renamed files

@urseberry urseberry self-assigned this Jun 12, 2025
Copy link
Contributor

@urseberry urseberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The renames and aliases are very clean! Nice job.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file omitted from the left nav?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. Why is this file omitted from the left nav?

Copy link
Contributor Author

@domalessi domalessi Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These pages are not currently in the left nav, so I'm not adding them. I don't know why they're not included, but I'll make a note to discuss this with the PM. I'd like to not block on this though since I'm maintaining what exists currently! Let me know what you think.

@domalessi domalessi requested a review from urseberry June 13, 2025 16:52
@domalessi domalessi merged commit f1afe64 into master Jun 13, 2025
21 of 23 checks passed
@domalessi domalessi deleted the domalessi/docs-10698-di-toc branch June 13, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants