Skip to content

initial documentation for preview mode permissions #28842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 24, 2025

Conversation

bi1yeu
Copy link
Contributor

@bi1yeu bi1yeu commented Apr 17, 2025

What does this PR do? What is the motivation?

On AAA Core Access we are introducing a new state for permisisons called "Preview Mode". In preview mode a permission will be visible but not enforced. This gives administrators with custom roles the ability to opt in to certain new permissions before losing access to resources that were previously unrestricted.

This change adds a brief section to the public permissions documentation so that we can reference it in release notes, product links, etc.

Here's rendered preview

Screenshot 2025-04-17 at 2 27 07 PM

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

cc @DataDog/aaa-core-access

@bi1yeu bi1yeu requested a review from aaronherrmann April 17, 2025 17:36
@bi1yeu bi1yeu added the aaa-access AAA Access team: https://datadoghq.atlassian.net/wiki/spaces/AAA/pages/2069365080/AAA+Access+Team label Apr 17, 2025
@bi1yeu bi1yeu marked this pull request as ready for review April 17, 2025 17:36
@bi1yeu bi1yeu requested a review from a team as a code owner April 17, 2025 17:36
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small optional suggestions here - looks great!

@bi1yeu
Copy link
Contributor Author

bi1yeu commented Apr 22, 2025

make role and permission top level headings

Copy link
Contributor

@aaronherrmann aaronherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bi1yeu
Copy link
Contributor Author

bi1yeu commented Apr 24, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 24, 2025

View all feedbacks in Devflow UI.

2025-04-24 14:00:55 UTC ℹ️ Start processing command /merge


2025-04-24 14:01:05 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-04-24 14:19:19 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 19m (p90).


2025-04-24 14:36:25 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit c98ab71 into master Apr 24, 2025
18 of 19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the matthew.bilyeu/ACCESS-3350/preview-mode-docs branch April 24, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aaa-access AAA Access team: https://datadoghq.atlassian.net/wiki/spaces/AAA/pages/2069365080/AAA+Access+Team mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants