Skip to content

[CCM] update anomalies list img #28835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jonathankauch
Copy link
Contributor

What does this PR do? What is the motivation?

Updating img to have better anomalies shown

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@jonathankauch jonathankauch requested a review from a team as a code owner April 17, 2025 11:50
@github-actions github-actions bot added the Images Images are added/removed with this PR label Apr 17, 2025
Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jojo, this looks great! One quirk of our site generator is that if you update an image, you actually need to give the new version a new filename, so we don't keep caching the old one and show it after the new one is uploaded.

Could you please rename your image (you don't have to delete the old one; we have a script for that) and update the one reference we have in the docs to it? If you need any help with that, don't hesitate to let me know! Then we can avoid the caching issue and have this lovely new image displaying properly for everyone 🙂

@jonathankauch
Copy link
Contributor Author

Hopefully it's good enough! Let me know if I need to change again 🙏

Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for the rename! :shipit:

@janine-c
Copy link
Contributor

Feel free to comment with /merge to add it to the merge queue whenever you're ready 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Images Images are added/removed with this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants