Skip to content

Conversation

p-datadog
Copy link
Member

@p-datadog p-datadog commented Sep 24, 2025

What does this PR do?

Loosens the restriction that line number and method name cannot be specified in a probe simultaneously.

Motivation:
Java and, shortly, Go provide the type name and method name for line probes. The use case in Go is to make line instrumentation feasible from the performance standpoint. Additionally, in all languages, having the type and method information for line probes permits (in theory) the library to verify that the line being instrumented is in the expected method, essentially verifying that the source code that the customer saw in UI when they selected the probe location matches the source code in the running application.

This PR brings Ruby DI implementation in alignment with Java and Go, so that if in the future backend starts sending type/method name with line probes, existing Ruby applications will not be broken.

Change log entry
None

Additional Notes:

How to test the change?
Unit tests altered

Copy link

github-actions bot commented Sep 24, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-09-24 15:32:40 UTC

@datadog-datadog-prod-us1
Copy link
Contributor

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 95.19%

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8087c65 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Sep 24, 2025

Benchmarks

Benchmark execution time: 2025-09-24 15:55:36

Comparing candidate commit 8087c65 in PR branch di-probe-fields with baseline commit 8275ac0 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics.

scenario:profiling - intern_all 1000 repeated strings

  • 🟩 throughput [+3949.412op/s; +4019.281op/s] or [+19.756%; +20.105%]

@p-datadog p-datadog marked this pull request as ready for review September 24, 2025 15:57
@p-datadog p-datadog requested a review from a team as a code owner September 24, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants