DI: permit line number & method name at the same time #4911
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Loosens the restriction that line number and method name cannot be specified in a probe simultaneously.
Motivation:
Java and, shortly, Go provide the type name and method name for line probes. The use case in Go is to make line instrumentation feasible from the performance standpoint. Additionally, in all languages, having the type and method information for line probes permits (in theory) the library to verify that the line being instrumented is in the expected method, essentially verifying that the source code that the customer saw in UI when they selected the probe location matches the source code in the running application.
This PR brings Ruby DI implementation in alignment with Java and Go, so that if in the future backend starts sending type/method name with line probes, existing Ruby applications will not be broken.
Change log entry
None
Additional Notes:
How to test the change?
Unit tests altered