-
Notifications
You must be signed in to change notification settings - Fork 468
ci: fix flaky test_partial_flush_log stdout #15285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 241 ± 3 ms. The average import time from base is: 250 ± 3 ms. The import time difference between this PR and base is: -9.2 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate brettlangdon/improve.flaky.test (238fa47) with baseline main (be7f4cb) 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.189µs (SLO: <10.000µs 📉 -48.1%) vs baseline: 📈 +24.3% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ ospathbasename_noaspectTime: ✅ 1.082µs (SLO: <10.000µs 📉 -89.2%) vs baseline: +0.8% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +5.3% ✅ ospathjoin_aspectTime: ✅ 6.046µs (SLO: <10.000µs 📉 -39.5%) vs baseline: -1.5% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +5.1% ✅ ospathjoin_noaspectTime: ✅ 2.300µs (SLO: <10.000µs 📉 -77.0%) vs baseline: +0.5% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +5.1% ✅ ospathnormcase_aspectTime: ✅ 3.657µs (SLO: <10.000µs 📉 -63.4%) vs baseline: +5.9% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ ospathnormcase_noaspectTime: ✅ 0.566µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.8% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +5.1% ✅ ospathsplit_aspectTime: ✅ 4.870µs (SLO: <10.000µs 📉 -51.3%) vs baseline: +2.3% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +5.1% ✅ ospathsplit_noaspectTime: ✅ 1.593µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +0.5% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +5.3% ✅ ospathsplitdrive_aspectTime: ✅ 3.624µs (SLO: <10.000µs 📉 -63.8%) vs baseline: -1.2% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +5.2% ✅ ospathsplitdrive_noaspectTime: ✅ 0.695µs (SLO: <10.000µs 📉 -93.0%) vs baseline: +0.4% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ ospathsplitext_aspectTime: ✅ 4.538µs (SLO: <10.000µs 📉 -54.6%) vs baseline: +0.2% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +5.0% ✅ ospathsplitext_noaspectTime: ✅ 1.393µs (SLO: <10.000µs 📉 -86.1%) vs baseline: +1.1% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.3% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.992µs (SLO: <20.000µs 📉 -85.0%) vs baseline: +1.9% Memory: ✅ 31.733MB (SLO: <34.000MB -6.7%) vs baseline: +5.7% ✅ 1-count-metrics-100-timesTime: ✅ 199.968µs (SLO: <220.000µs -9.1%) vs baseline: -0.8% Memory: ✅ 31.595MB (SLO: <34.000MB -7.1%) vs baseline: +5.1% ✅ 1-distribution-metric-1-timesTime: ✅ 3.394µs (SLO: <20.000µs 📉 -83.0%) vs baseline: +2.4% Memory: ✅ 31.634MB (SLO: <34.000MB -7.0%) vs baseline: +5.2% ✅ 1-distribution-metrics-100-timesTime: ✅ 217.908µs (SLO: <220.000µs 🟡 -1.0%) vs baseline: +1.3% Memory: ✅ 31.949MB (SLO: <34.000MB -6.0%) vs baseline: +6.5% ✅ 1-gauge-metric-1-timesTime: ✅ 2.473µs (SLO: <20.000µs 📉 -87.6%) vs baseline: 📈 +11.2% Memory: ✅ 31.752MB (SLO: <34.000MB -6.6%) vs baseline: +5.8% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.548µs (SLO: <150.000µs -9.0%) vs baseline: -1.4% Memory: ✅ 31.634MB (SLO: <34.000MB -7.0%) vs baseline: +5.2% ✅ 1-rate-metric-1-timesTime: ✅ 3.407µs (SLO: <20.000µs 📉 -83.0%) vs baseline: 📈 +10.4% Memory: ✅ 31.693MB (SLO: <34.000MB -6.8%) vs baseline: +5.6% ✅ 1-rate-metrics-100-timesTime: ✅ 213.247µs (SLO: <250.000µs 📉 -14.7%) vs baseline: -0.7% Memory: ✅ 31.674MB (SLO: <34.000MB -6.8%) vs baseline: +5.5% ✅ 100-count-metrics-100-timesTime: ✅ 20.172ms (SLO: <22.000ms -8.3%) vs baseline: -0.8% Memory: ✅ 31.968MB (SLO: <34.000MB -6.0%) vs baseline: +6.3% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.256ms (SLO: <2.300ms 🟡 -1.9%) vs baseline: +0.7% Memory: ✅ 32.008MB (SLO: <34.000MB -5.9%) vs baseline: +5.6% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.412ms (SLO: <1.550ms -8.9%) vs baseline: ~same Memory: ✅ 32.008MB (SLO: <34.000MB -5.9%) vs baseline: +6.7% ✅ 100-rate-metrics-100-timesTime: ✅ 2.205ms (SLO: <2.550ms 📉 -13.5%) vs baseline: -0.8% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +6.9% ✅ flush-1-metricTime: ✅ 4.635µs (SLO: <20.000µs 📉 -76.8%) vs baseline: +1.5% Memory: ✅ 32.027MB (SLO: <34.000MB -5.8%) vs baseline: +5.4% ✅ flush-100-metricsTime: ✅ 175.579µs (SLO: <250.000µs 📉 -29.8%) vs baseline: +0.8% Memory: ✅ 32.027MB (SLO: <34.000MB -5.8%) vs baseline: +5.4% ✅ flush-1000-metricsTime: ✅ 2.118ms (SLO: <2.500ms 📉 -15.3%) vs baseline: ~same Memory: ✅ 32.755MB (SLO: <34.500MB -5.1%) vs baseline: +5.2% 🟡 Near SLO Breach (4 suites)🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 16.341ms (SLO: <19.850ms 📉 -17.7%) vs baseline: ~same Memory: ✅ 65.726MB (SLO: <66.500MB 🟡 -1.2%) vs baseline: +5.2% ✅ errortracking-enabled-userTime: ✅ 16.340ms (SLO: <19.400ms 📉 -15.8%) vs baseline: +0.2% Memory: ✅ 65.765MB (SLO: <66.500MB 🟡 -1.1%) vs baseline: +5.1% ✅ tracer-enabledTime: ✅ 16.336ms (SLO: <19.450ms 📉 -16.0%) vs baseline: -0.2% Memory: ✅ 65.824MB (SLO: <66.500MB 🟡 -1.0%) vs baseline: +5.2% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.072ms (SLO: <2.300ms -9.9%) vs baseline: ~same Memory: ✅ 52.553MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +5.3% ✅ errortracking-enabled-userTime: ✅ 2.073ms (SLO: <2.250ms -7.9%) vs baseline: +0.5% Memory: ✅ 52.396MB (SLO: <53.500MB -2.1%) vs baseline: +5.1% ✅ tracer-enabledTime: ✅ 2.064ms (SLO: <2.300ms 📉 -10.3%) vs baseline: ~same Memory: ✅ 52.573MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +5.1% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.587ms (SLO: <4.750ms -3.4%) vs baseline: +0.3% Memory: ✅ 62.128MB (SLO: <65.000MB -4.4%) vs baseline: +5.1% ✅ appsec-postTime: ✅ 6.619ms (SLO: <6.750ms 🟡 -1.9%) vs baseline: ~same Memory: ✅ 62.285MB (SLO: <65.000MB -4.2%) vs baseline: +5.3% ✅ appsec-telemetryTime: ✅ 4.592ms (SLO: <4.750ms -3.3%) vs baseline: -0.1% Memory: ✅ 62.089MB (SLO: <65.000MB -4.5%) vs baseline: +5.0% ✅ debuggerTime: ✅ 1.870ms (SLO: <2.000ms -6.5%) vs baseline: +0.3% Memory: ✅ 45.298MB (SLO: <47.000MB -3.6%) vs baseline: +5.2% ✅ iast-getTime: ✅ 1.853ms (SLO: <2.000ms -7.3%) vs baseline: -0.1% Memory: ✅ 42.192MB (SLO: <49.000MB 📉 -13.9%) vs baseline: +6.2% ✅ profilerTime: ✅ 1.913ms (SLO: <2.100ms -8.9%) vs baseline: -0.6% Memory: ✅ 46.537MB (SLO: <47.000MB 🟡 -1.0%) vs baseline: +5.3% ✅ resource-renamingTime: ✅ 3.367ms (SLO: <3.650ms -7.8%) vs baseline: +0.1% Memory: ✅ 52.691MB (SLO: <53.500MB 🟡 -1.5%) vs baseline: +5.5% ✅ tracerTime: ✅ 3.357ms (SLO: <3.650ms -8.0%) vs baseline: +0.3% Memory: ✅ 52.357MB (SLO: <53.500MB -2.1%) vs baseline: +5.1% ✅ tracer-nativeTime: ✅ 3.358ms (SLO: <3.650ms -8.0%) vs baseline: +0.4% Memory: ✅ 54.260MB (SLO: <60.000MB -9.6%) vs baseline: +5.3% 🟡 recursivecomputation - 8/8✅ deepTime: ✅ 308.447ms (SLO: <320.950ms -3.9%) vs baseline: -0.2% Memory: ✅ 32.873MB (SLO: <34.500MB -4.7%) vs baseline: +5.6% ✅ deep-profiledTime: ✅ 327.729ms (SLO: <359.150ms -8.7%) vs baseline: -0.2% Memory: ✅ 38.653MB (SLO: <39.000MB 🟡 -0.9%) vs baseline: +5.8% ✅ mediumTime: ✅ 7.007ms (SLO: <7.400ms -5.3%) vs baseline: -0.1% Memory: ✅ 31.556MB (SLO: <34.000MB -7.2%) vs baseline: +5.2% ✅ shallowTime: ✅ 0.943ms (SLO: <1.050ms 📉 -10.2%) vs baseline: +0.5% Memory: ✅ 31.615MB (SLO: <34.000MB -7.0%) vs baseline: +5.4%
|
|
I realized, a better way is probably just to set Since the tests is already validating a specific log is happening, we don't really need to care about any of the other logs. I'll update next week to fix. |
Description
Attempt to address the flaky test
test_partial_flush_logThis is just a race condition with flushing and logging, it is safe to ignore.
Testing
Risks
Additional Notes