-
Notifications
You must be signed in to change notification settings - Fork 468
chore(tornado): v4.0 deprecations #15274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 255 ± 4 ms. The average import time from base is: 255 ± 3 ms. The import time difference between this PR and base is: 0.0 ± 0.2 ms. The difference is not statistically significant (z = 0.31). Import time breakdownThe following import paths have grown:
|
brettlangdon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are moving too quick here with some of the removals, this should be deprecation warnings only for tornado version support and public API deprecation only.
removals should come later.
releasenotes/notes/deprecate-older-tornado-versions-381d2f4e6c4c8288.yaml
Show resolved
Hide resolved
|
I don't think this makes sense as a 4.0 backport. It looks to me like this diff is mostly about deprecating rather than removing, which is appropriate for 3.19. |
Performance SLOsComparing candidate munir/deprecate-tornado-p-api (a07d8cd) with baseline main (73f2611) 📈 Performance Regressions (1 suite)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.351µs (SLO: <10.000µs 📉 -56.5%) vs baseline: +1.0% Memory: ✅ 39.754MB (SLO: <41.000MB -3.0%) vs baseline: +4.7% ✅ ospathbasename_noaspectTime: ✅ 1.100µs (SLO: <10.000µs 📉 -89.0%) vs baseline: +0.9% Memory: ✅ 39.754MB (SLO: <41.000MB -3.0%) vs baseline: +4.5% ✅ ospathjoin_aspectTime: ✅ 6.145µs (SLO: <10.000µs 📉 -38.5%) vs baseline: -0.7% Memory: ✅ 39.911MB (SLO: <41.000MB -2.7%) vs baseline: +4.9% ✅ ospathjoin_noaspectTime: ✅ 2.296µs (SLO: <10.000µs 📉 -77.0%) vs baseline: +0.5% Memory: ✅ 39.892MB (SLO: <41.000MB -2.7%) vs baseline: +5.1% ✅ ospathnormcase_aspectTime: ✅ 3.579µs (SLO: <10.000µs 📉 -64.2%) vs baseline: +0.8% Memory: ✅ 39.911MB (SLO: <41.000MB -2.7%) vs baseline: +4.9% ✅ ospathnormcase_noaspectTime: ✅ 0.572µs (SLO: <10.000µs 📉 -94.3%) vs baseline: ~same Memory: ✅ 39.931MB (SLO: <41.000MB -2.6%) vs baseline: +5.4% ✅ ospathsplit_aspectTime: ✅ 4.852µs (SLO: <10.000µs 📉 -51.5%) vs baseline: ~same Memory: ✅ 39.872MB (SLO: <41.000MB -2.8%) vs baseline: +4.6% ✅ ospathsplit_noaspectTime: ✅ 1.591µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +0.7% Memory: ✅ 39.931MB (SLO: <41.000MB -2.6%) vs baseline: +4.9% ✅ ospathsplitdrive_aspectTime: ✅ 4.098µs (SLO: <10.000µs 📉 -59.0%) vs baseline: 📈 +10.0% Memory: ✅ 39.872MB (SLO: <41.000MB -2.8%) vs baseline: +5.1% ✅ ospathsplitdrive_noaspectTime: ✅ 0.696µs (SLO: <10.000µs 📉 -93.0%) vs baseline: +0.3% Memory: ✅ 39.833MB (SLO: <41.000MB -2.8%) vs baseline: +5.0% ✅ ospathsplitext_aspectTime: ✅ 4.626µs (SLO: <10.000µs 📉 -53.7%) vs baseline: ~same Memory: ✅ 39.754MB (SLO: <41.000MB -3.0%) vs baseline: +4.5% ✅ ospathsplitext_noaspectTime: ✅ 1.400µs (SLO: <10.000µs 📉 -86.0%) vs baseline: +1.4% Memory: ✅ 39.872MB (SLO: <41.000MB -2.8%) vs baseline: +4.9% 🟡 Near SLO Breach (1 suite)🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.984µs (SLO: <20.000µs 📉 -85.1%) vs baseline: +2.4% Memory: ✅ 34.583MB (SLO: <35.500MB -2.6%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 198.945µs (SLO: <220.000µs -9.6%) vs baseline: -0.3% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +5.0% ✅ 1-distribution-metric-1-timesTime: ✅ 3.403µs (SLO: <20.000µs 📉 -83.0%) vs baseline: +2.8% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +5.0% ✅ 1-distribution-metrics-100-timesTime: ✅ 217.424µs (SLO: <220.000µs 🟡 -1.2%) vs baseline: +0.1% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.238µs (SLO: <20.000µs 📉 -88.8%) vs baseline: +2.6% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.989µs (SLO: <150.000µs -8.0%) vs baseline: -0.2% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +4.8% ✅ 1-rate-metric-1-timesTime: ✅ 3.148µs (SLO: <20.000µs 📉 -84.3%) vs baseline: +2.2% Memory: ✅ 34.406MB (SLO: <35.500MB -3.1%) vs baseline: +4.4% ✅ 1-rate-metrics-100-timesTime: ✅ 212.488µs (SLO: <250.000µs 📉 -15.0%) vs baseline: -0.5% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +4.7% ✅ 100-count-metrics-100-timesTime: ✅ 20.003ms (SLO: <22.000ms -9.1%) vs baseline: -1.1% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +5.1% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.303ms (SLO: <2.300ms +0.1%) vs baseline: +1.2% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +5.2% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.426ms (SLO: <1.550ms -8.0%) vs baseline: +0.5% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +5.0% ✅ 100-rate-metrics-100-timesTime: ✅ 2.201ms (SLO: <2.550ms 📉 -13.7%) vs baseline: ~same Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +4.6% ✅ flush-1-metricTime: ✅ 4.622µs (SLO: <20.000µs 📉 -76.9%) vs baseline: +0.3% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +5.0% ✅ flush-100-metricsTime: ✅ 174.566µs (SLO: <250.000µs 📉 -30.2%) vs baseline: +0.7% Memory: ✅ 34.505MB (SLO: <35.500MB -2.8%) vs baseline: +4.6% ✅ flush-1000-metricsTime: ✅ 2.112ms (SLO: <2.500ms 📉 -15.5%) vs baseline: -0.2% Memory: ✅ 35.350MB (SLO: <36.500MB -3.2%) vs baseline: +4.9%
|
a7cb749 to
db1f08f
Compare
I just want the same set of changes in both 3.19 and 4.0 branches. Then in 4.0 we can do the removals in a follow up PR. That way we keep the commit histories consistent across branches and reduce the likelihood of merge conflicts. |
Description
Deprecated Tornado versions older than v6.1 and programmatic configuration via ddtrace.contrib.tornado. Users should upgrade to Tornado v6.1+ and use environment variables with import ddtrace.auto.
Motivation
Tornado v6.1 (released in 2020) added contextvars support, eliminating the need for a custom Tornado Context Provider. This allows us to remove the last integration specific Context Provider and simplify our context API.