-
Notifications
You must be signed in to change notification settings - Fork 464
fix(llmobs): remove version setting in langchain auto prompt template [backport 3.16] #14989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.16
Are you sure you want to change the base?
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 238 ± 1 ms. The average import time from base is: 240 ± 1 ms. The import time difference between this PR and base is: -2.16 ± 0.06 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate backport-14937-to-3.16 (8850b55) with baseline 3.16 (de9dbc1) 📈 Performance Regressions (1 suite)📈 iast_aspects - 40/40✅ re_expand_aspectTime: ✅ 31.980µs (SLO: <40.000µs 📉 -20.1%) vs baseline: -0.3% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ re_expand_noaspectTime: ✅ 28.433µs (SLO: <40.000µs 📉 -28.9%) vs baseline: -0.3% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.1% ✅ re_findall_aspectTime: ✅ 2.920µs (SLO: <10.000µs 📉 -70.8%) vs baseline: +0.4% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.8% ✅ re_findall_noaspectTime: ✅ 1.423µs (SLO: <10.000µs 📉 -85.8%) vs baseline: -0.5% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ re_finditer_aspectTime: ✅ 4.503µs (SLO: <10.000µs 📉 -55.0%) vs baseline: +2.0% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ re_finditer_noaspectTime: ✅ 1.414µs (SLO: <10.000µs 📉 -85.9%) vs baseline: -0.5% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.6% ✅ re_fullmatch_aspectTime: ✅ 2.950µs (SLO: <10.000µs 📉 -70.5%) vs baseline: 📈 +10.1% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ re_fullmatch_noaspectTime: ✅ 1.288µs (SLO: <10.000µs 📉 -87.1%) vs baseline: ~same Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ re_group_aspectTime: ✅ 3.229µs (SLO: <10.000µs 📉 -67.7%) vs baseline: 📈 +10.4% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ re_group_noaspectTime: ✅ 1.608µs (SLO: <10.000µs 📉 -83.9%) vs baseline: +0.4% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ re_groups_aspectTime: ✅ 3.317µs (SLO: <10.000µs 📉 -66.8%) vs baseline: +7.7% Memory: ✅ 37.572MB (SLO: <39.000MB -3.7%) vs baseline: +4.6% ✅ re_groups_noaspectTime: ✅ 1.724µs (SLO: <10.000µs 📉 -82.8%) vs baseline: +2.5% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ re_match_aspectTime: ✅ 3.012µs (SLO: <10.000µs 📉 -69.9%) vs baseline: 📈 +10.5% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ re_match_noaspectTime: ✅ 1.277µs (SLO: <10.000µs 📉 -87.2%) vs baseline: -1.9% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ re_search_aspectTime: ✅ 2.770µs (SLO: <10.000µs 📉 -72.3%) vs baseline: +7.4% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ re_search_noaspectTime: ✅ 1.205µs (SLO: <10.000µs 📉 -88.0%) vs baseline: ~same Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ re_sub_aspectTime: ✅ 3.577µs (SLO: <10.000µs 📉 -64.2%) vs baseline: +4.8% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.6% ✅ re_sub_noaspectTime: ✅ 1.525µs (SLO: <10.000µs 📉 -84.7%) vs baseline: +0.3% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ re_subn_aspectTime: ✅ 3.883µs (SLO: <10.000µs 📉 -61.2%) vs baseline: +5.8% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ re_subn_noaspectTime: ✅ 1.607µs (SLO: <10.000µs 📉 -83.9%) vs baseline: -0.7% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.6% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.492ms (SLO: <22.300ms -8.1%) vs baseline: +0.2% Memory: ✅ 65.529MB (SLO: <67.000MB -2.2%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.345ms (SLO: <1.450ms -7.2%) vs baseline: ~same Memory: ✅ 64.494MB (SLO: <67.000MB -3.7%) vs baseline: +4.9% ✅ iastTime: ✅ 20.461ms (SLO: <22.250ms -8.0%) vs baseline: ~same Memory: ✅ 65.488MB (SLO: <67.000MB -2.3%) vs baseline: +4.8% ✅ profilerTime: ✅ 15.296ms (SLO: <16.550ms -7.6%) vs baseline: +0.4% Memory: ✅ 53.668MB (SLO: <54.500MB 🟡 -1.5%) vs baseline: +4.4% ✅ resource-renamingTime: ✅ 20.602ms (SLO: <21.750ms -5.3%) vs baseline: +0.3% Memory: ✅ 65.537MB (SLO: <67.000MB -2.2%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 26.121ms (SLO: <28.200ms -7.4%) vs baseline: -0.3% Memory: ✅ 67.769MB (SLO: <69.500MB -2.5%) vs baseline: +4.3% ✅ tracerTime: ✅ 20.427ms (SLO: <21.750ms -6.1%) vs baseline: -0.4% Memory: ✅ 65.560MB (SLO: <67.000MB -2.1%) vs baseline: +5.0% ✅ tracer-and-profilerTime: ✅ 22.039ms (SLO: <23.500ms -6.2%) vs baseline: +0.1% Memory: ✅ 66.567MB (SLO: <67.500MB 🟡 -1.4%) vs baseline: +5.0% ✅ tracer-dont-create-db-spansTime: ✅ 19.400ms (SLO: <21.500ms -9.8%) vs baseline: +0.7% Memory: ✅ 65.531MB (SLO: <66.000MB 🟡 -0.7%) vs baseline: +4.8% ✅ tracer-minimalTime: ✅ 16.631ms (SLO: <17.500ms -5.0%) vs baseline: ~same Memory: ✅ 65.552MB (SLO: <66.000MB 🟡 -0.7%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 20.561ms (SLO: <21.750ms -5.5%) vs baseline: +0.8% Memory: ✅ 71.432MB (SLO: <72.500MB 🟡 -1.5%) vs baseline: +4.9% ✅ tracer-no-cachesTime: ✅ 18.396ms (SLO: <19.650ms -6.4%) vs baseline: -0.1% Memory: ✅ 65.496MB (SLO: <67.000MB -2.2%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.768ms (SLO: <20.100ms -6.6%) vs baseline: +0.1% Memory: ✅ 65.454MB (SLO: <67.000MB -2.3%) vs baseline: +4.8% ✅ tracer-no-middlewareTime: ✅ 20.180ms (SLO: <21.500ms -6.1%) vs baseline: +0.2% Memory: ✅ 65.449MB (SLO: <67.000MB -2.3%) vs baseline: +4.8% ✅ tracer-no-templatesTime: ✅ 20.305ms (SLO: <22.000ms -7.7%) vs baseline: ~same Memory: ✅ 65.573MB (SLO: <67.000MB -2.1%) vs baseline: +4.9% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.119ms (SLO: <19.850ms -8.7%) vs baseline: -0.2% Memory: ✅ 65.352MB (SLO: <66.500MB 🟡 -1.7%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.111ms (SLO: <19.400ms -6.6%) vs baseline: +0.4% Memory: ✅ 65.352MB (SLO: <66.500MB 🟡 -1.7%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 18.064ms (SLO: <19.450ms -7.1%) vs baseline: -0.4% Memory: ✅ 65.333MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +4.9% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.569ms (SLO: <4.750ms -3.8%) vs baseline: +0.2% Memory: ✅ 62.010MB (SLO: <65.000MB -4.6%) vs baseline: +5.0% ✅ appsec-postTime: ✅ 6.559ms (SLO: <6.750ms -2.8%) vs baseline: ~same Memory: ✅ 62.030MB (SLO: <65.000MB -4.6%) vs baseline: +5.0% ✅ appsec-telemetryTime: ✅ 4.573ms (SLO: <4.750ms -3.7%) vs baseline: ~same Memory: ✅ 61.932MB (SLO: <65.000MB -4.7%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.854ms (SLO: <2.000ms -7.3%) vs baseline: ~same Memory: ✅ 45.397MB (SLO: <47.000MB -3.4%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.861ms (SLO: <2.000ms -6.9%) vs baseline: ~same Memory: ✅ 42.290MB (SLO: <49.000MB 📉 -13.7%) vs baseline: +4.6% ✅ profilerTime: ✅ 1.911ms (SLO: <2.100ms -9.0%) vs baseline: ~same Memory: ✅ 46.439MB (SLO: <47.000MB 🟡 -1.2%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 3.382ms (SLO: <3.650ms -7.3%) vs baseline: +0.1% Memory: ✅ 52.258MB (SLO: <53.500MB -2.3%) vs baseline: +4.9% ✅ tracerTime: ✅ 3.362ms (SLO: <3.650ms -7.9%) vs baseline: -0.2% Memory: ✅ 52.199MB (SLO: <53.500MB -2.4%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.372ms (SLO: <3.650ms -7.6%) vs baseline: ~same Memory: ✅ 58.152MB (SLO: <60.000MB -3.1%) vs baseline: +4.8% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 42.528ms (SLO: <47.150ms -9.8%) vs baseline: +0.2% Memory: ✅ 44.515MB (SLO: <47.000MB -5.3%) vs baseline: +4.9% ✅ add-metricsTime: ✅ 316.141ms (SLO: <344.800ms -8.3%) vs baseline: +0.4% Memory: ✅ 594.641MB (SLO: <600.000MB 🟡 -0.9%) vs baseline: +5.0% ✅ add-tagsTime: ✅ 288.711ms (SLO: <314.000ms -8.1%) vs baseline: +0.8% Memory: ✅ 595.902MB (SLO: <600.000MB 🟡 -0.7%) vs baseline: +4.8% ✅ get-contextTime: ✅ 80.699ms (SLO: <92.350ms 📉 -12.6%) vs baseline: +0.2% Memory: ✅ 39.989MB (SLO: <46.500MB 📉 -14.0%) vs baseline: +4.9% ✅ is-recordingTime: ✅ 39.131ms (SLO: <44.500ms 📉 -12.1%) vs baseline: +0.4% Memory: ✅ 43.964MB (SLO: <47.500MB -7.4%) vs baseline: +4.8% ✅ record-exceptionTime: ✅ 59.004ms (SLO: <67.650ms 📉 -12.8%) vs baseline: +0.6% Memory: ✅ 40.274MB (SLO: <47.000MB 📉 -14.3%) vs baseline: +4.8% ✅ set-statusTime: ✅ 44.919ms (SLO: <50.400ms 📉 -10.9%) vs baseline: +0.2% Memory: ✅ 43.943MB (SLO: <47.000MB -6.5%) vs baseline: +4.8% ✅ startTime: ✅ 38.176ms (SLO: <43.450ms 📉 -12.1%) vs baseline: ~same Memory: ✅ 43.994MB (SLO: <47.000MB -6.4%) vs baseline: +4.8% ✅ start-finishTime: ✅ 84.437ms (SLO: <88.000ms -4.0%) vs baseline: +1.9% Memory: ✅ 34.583MB (SLO: <46.500MB 📉 -25.6%) vs baseline: +4.7% ✅ start-finish-telemetryTime: ✅ 84.255ms (SLO: <89.000ms -5.3%) vs baseline: ~same Memory: ✅ 34.544MB (SLO: <46.500MB 📉 -25.7%) vs baseline: +4.8% ✅ update-nameTime: ✅ 40.341ms (SLO: <45.150ms 📉 -10.7%) vs baseline: +0.1% Memory: ✅ 44.273MB (SLO: <47.000MB -5.8%) vs baseline: +4.8% 🟡 span - 26/26✅ add-eventTime: ✅ 20.748ms (SLO: <22.500ms -7.8%) vs baseline: +0.4% Memory: ✅ 50.217MB (SLO: <53.000MB -5.3%) vs baseline: +4.6% ✅ add-metricsTime: ✅ 90.617ms (SLO: <93.500ms -3.1%) vs baseline: +0.4% Memory: ✅ 661.066MB (SLO: <961.000MB 📉 -31.2%) vs baseline: +4.9% ✅ add-tagsTime: ✅ 148.996ms (SLO: <155.000ms -3.9%) vs baseline: +0.4% Memory: ✅ 661.566MB (SLO: <962.500MB 📉 -31.3%) vs baseline: +4.9% ✅ get-contextTime: ✅ 19.490ms (SLO: <20.500ms -4.9%) vs baseline: +0.7% Memory: ✅ 49.151MB (SLO: <53.000MB -7.3%) vs baseline: +4.9% ✅ is-recordingTime: ✅ 19.770ms (SLO: <20.500ms -3.6%) vs baseline: +1.1% Memory: ✅ 49.124MB (SLO: <53.000MB -7.3%) vs baseline: +4.8% ✅ record-exceptionTime: ✅ 38.658ms (SLO: <40.000ms -3.4%) vs baseline: +0.8% Memory: ✅ 42.762MB (SLO: <53.000MB 📉 -19.3%) vs baseline: +4.9% ✅ set-statusTime: ✅ 21.354ms (SLO: <22.000ms -2.9%) vs baseline: +0.3% Memory: ✅ 49.093MB (SLO: <53.000MB -7.4%) vs baseline: +5.0% ✅ startTime: ✅ 19.371ms (SLO: <20.500ms -5.5%) vs baseline: +0.3% Memory: ✅ 49.192MB (SLO: <53.000MB -7.2%) vs baseline: +4.9% ✅ start-finishTime: ✅ 51.596ms (SLO: <52.500ms 🟡 -1.7%) vs baseline: +0.3% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +5.0% ✅ start-finish-telemetryTime: ✅ 52.750ms (SLO: <54.500ms -3.2%) vs baseline: ~same Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.8% ✅ start-finish-traceid128Time: ✅ 54.775ms (SLO: <55.000ms 🟡 -0.4%) vs baseline: ~same Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +4.8% ✅ start-traceid128Time: ✅ 19.720ms (SLO: <22.500ms 📉 -12.4%) vs baseline: +0.4% Memory: ✅ 49.106MB (SLO: <53.000MB -7.3%) vs baseline: +4.9% ✅ update-nameTime: ✅ 20.325ms (SLO: <22.000ms -7.6%) vs baseline: +0.7% Memory: ✅ 49.773MB (SLO: <53.000MB -6.1%) vs baseline: +4.8%
|
…#14937) ## Description Remove setting version from auto instrumented prompt templates. We adjusted the way we interpret explicitly set versions. Auto instrumentation should not set one. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> (cherry picked from commit 8b7fe13)
8850b55 to
3a0e220
Compare
Backport 8b7fe13 from #14937 to 3.16.
Description
Remove setting version from auto instrumented prompt templates.
We adjusted the way we interpret explicitly set versions. Auto instrumentation should not set one.
Testing
Risks
Additional Notes