breaking changes for version 4.0 #14938
Conversation
This change removes the `cassandra` contrib package, which is only tested on the to-be-removed Python 3.8 runtime.
emmettbutler
requested review from
RamyElkest,
brettlangdon,
dd-oleksii and
wantsui
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 238 ± 2 ms. The average import time from base is: 239 ± 2 ms. The import time difference between this PR and base is: -1.34 ± 0.09 ms. Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate 4.0-breaking-changes (3d713e1) with baseline main (b8bafdb) ❌ Test Failures (1 suite)❌ telemetryaddmetric - 29/30✅ 1-count-metric-1-timesTime: ✅ 2.963µs (SLO: <20.000µs 📉 -85.2%) vs baseline: ~same Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.1% ✅ 1-count-metrics-100-timesTime: ✅ 202.601µs (SLO: <220.000µs -7.9%) vs baseline: -0.3% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +5.0% ✅ 1-distribution-metric-1-timesTime: ✅ 3.276µs (SLO: <20.000µs 📉 -83.6%) vs baseline: -1.7% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.2% ✅ 1-distribution-metrics-100-timesTime: ✅ 212.147µs (SLO: <220.000µs -3.6%) vs baseline: -2.3% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.7% ✅ 1-gauge-metric-1-timesTime: ✅ 2.156µs (SLO: <20.000µs 📉 -89.2%) vs baseline: -1.1% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.0% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.697µs (SLO: <150.000µs -8.9%) vs baseline: -1.0% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +5.0% ✅ 1-rate-metric-1-timesTime: ✅ 3.039µs (SLO: <20.000µs 📉 -84.8%) vs baseline: -2.1% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.7% ✅ 1-rate-metrics-100-timesTime: ✅ 215.610µs (SLO: <250.000µs 📉 -13.8%) vs baseline: -1.4% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.7% ✅ 100-count-metrics-100-timesTime: ✅ 20.828ms (SLO: <22.000ms -5.3%) vs baseline: +0.9% Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +5.2% ❌ 100-distribution-metrics-100-timesTime: ❌ 2.323ms (SLO: <2.300ms +1.0%) vs baseline: +2.2% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.8% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.415ms (SLO: <1.550ms -8.7%) vs baseline: +0.2% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.307ms (SLO: <2.550ms -9.5%) vs baseline: +3.3% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.8% ✅ flush-1-metricTime: ✅ 4.422µs (SLO: <20.000µs 📉 -77.9%) vs baseline: -0.2% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 172.928µs (SLO: <250.000µs 📉 -30.8%) vs baseline: -0.8% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.0% ✅ flush-1000-metricsTime: ✅ 2.110ms (SLO: <2.500ms 📉 -15.6%) vs baseline: -0.2% Memory: ✅ 32.873MB (SLO: <34.500MB -4.7%) vs baseline: +4.7% 📈 Performance Regressions (1 suite)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.409µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +1.1% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +3.9% ✅ add_inplace_aspectTime: ✅ 0.413µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.8% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +3.8% ✅ add_inplace_noaspectTime: ✅ 0.315µs (SLO: <10.000µs 📉 -96.9%) vs baseline: -2.0% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.0% ✅ add_noaspectTime: ✅ 0.279µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +2.0% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ bytearray_aspectTime: ✅ 1.350µs (SLO: <10.000µs 📉 -86.5%) vs baseline: +1.1% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +3.7% ✅ bytearray_extend_aspectTime: ✅ 1.589µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +4.2% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +3.6% ✅ bytearray_extend_noaspectTime: ✅ 0.612µs (SLO: <10.000µs 📉 -93.9%) vs baseline: +0.2% Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.3% ✅ bytearray_noaspectTime: ✅ 0.483µs (SLO: <10.000µs 📉 -95.2%) vs baseline: +0.4% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.0% ✅ bytes_aspectTime: ✅ 1.299µs (SLO: <10.000µs 📉 -87.0%) vs baseline: +0.9% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +3.9% ✅ bytes_noaspectTime: ✅ 0.495µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.2% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.0% ✅ bytesio_aspectTime: ✅ 1.331µs (SLO: <10.000µs 📉 -86.7%) vs baseline: -1.1% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +3.8% ✅ bytesio_noaspectTime: ✅ 0.498µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.8% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.0% ✅ capitalize_aspectTime: ✅ 0.745µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +1.1% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ capitalize_noaspectTime: ✅ 0.434µs (SLO: <10.000µs 📉 -95.7%) vs baseline: +0.4% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +3.8% ✅ casefold_aspectTime: ✅ 0.744µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.8% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +3.9% ✅ casefold_noaspectTime: ✅ 0.369µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.2% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.1% ✅ decode_aspectTime: ✅ 0.725µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.4% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.6% ✅ decode_noaspectTime: ✅ 0.418µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.2% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.0% ✅ encode_aspectTime: ✅ 0.711µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +0.6% Memory: ✅ 37.591MB (SLO: <39.000MB -3.6%) vs baseline: +4.3% ✅ encode_noaspectTime: ✅ 0.400µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.8% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +3.8% ✅ format_aspectTime: ✅ 3.519µs (SLO: <10.000µs 📉 -64.8%) vs baseline: +6.2% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.4% ✅ format_map_aspectTime: ✅ 3.574µs (SLO: <10.000µs 📉 -64.3%) vs baseline: -0.2% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +3.8% ✅ format_map_noaspectTime: ✅ 0.777µs (SLO: <10.000µs 📉 -92.2%) vs baseline: -0.5% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.1% ✅ format_noaspectTime: ✅ 0.596µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.2% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.0% ✅ index_aspectTime: ✅ 0.357µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +0.1% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +4.0% ✅ index_noaspectTime: ✅ 0.280µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +1.1% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.1% ✅ join_aspectTime: ✅ 1.319µs (SLO: <10.000µs 📉 -86.8%) vs baseline: -0.3% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +3.8% ✅ join_noaspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.5% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ ljust_aspectTime: ✅ 2.605µs (SLO: <20.000µs 📉 -87.0%) vs baseline: -0.2% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.2% ✅ ljust_noaspectTime: ✅ 0.401µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.4% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +4.2% ✅ lower_aspectTime: ✅ 2.255µs (SLO: <10.000µs 📉 -77.4%) vs baseline: +1.0% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.1% ✅ lower_noaspectTime: ✅ 0.369µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +1.2% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.3% ✅ lstrip_aspectTime: ✅ 2.216µs (SLO: <20.000µs 📉 -88.9%) vs baseline: +0.6% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.6% ✅ lstrip_noaspectTime: ✅ 0.385µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +0.4% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.0% ✅ modulo_aspectTime: ✅ 0.998µs (SLO: <10.000µs 📉 -90.0%) vs baseline: +0.9% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.2% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.545µs (SLO: <10.000µs 📉 -84.6%) vs baseline: +1.2% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +3.7% ✅ modulo_aspect_for_bytesTime: ✅ 0.978µs (SLO: <10.000µs 📉 -90.2%) vs baseline: -0.6% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +3.9% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.206µs (SLO: <10.000µs 📉 -87.9%) vs baseline: -0.2% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.6% ✅ modulo_noaspectTime: ✅ 0.628µs (SLO: <10.000µs 📉 -93.7%) vs baseline: -0.3% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.0% ✅ replace_aspectTime: ✅ 4.858µs (SLO: <10.000µs 📉 -51.4%) vs baseline: +0.5% Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +5.1% ✅ replace_noaspectTime: ✅ 0.461µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -0.7% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.1% ✅ repr_aspectTime: ✅ 0.910µs (SLO: <10.000µs 📉 -90.9%) vs baseline: +0.8% Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +4.0% ✅ repr_noaspectTime: ✅ 0.415µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.4% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.6% ✅ rstrip_aspectTime: ✅ 1.949µs (SLO: <20.000µs 📉 -90.3%) vs baseline: +2.4% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.0% ✅ rstrip_noaspectTime: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.8% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +3.9% ✅ slice_aspectTime: ✅ 0.495µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.5% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +3.7% ✅ slice_noaspectTime: ✅ 0.443µs (SLO: <10.000µs 📉 -95.6%) vs baseline: -1.2% Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +4.3% ✅ stringio_aspectTime: ✅ 1.561µs (SLO: <10.000µs 📉 -84.4%) vs baseline: +0.5% Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +5.0% ✅ stringio_noaspectTime: ✅ 0.716µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +0.3% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +3.8% ✅ strip_aspectTime: ✅ 2.485µs (SLO: <20.000µs 📉 -87.6%) vs baseline: 📈 +12.9% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.0% ✅ strip_noaspectTime: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: ~same Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.2% ✅ swapcase_aspectTime: ✅ 2.448µs (SLO: <10.000µs 📉 -75.5%) vs baseline: -0.1% Memory: ✅ 37.886MB (SLO: <39.000MB -2.9%) vs baseline: +5.5% ✅ swapcase_noaspectTime: ✅ 0.533µs (SLO: <10.000µs 📉 -94.7%) vs baseline: -0.4% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.0% ✅ title_aspectTime: ✅ 2.519µs (SLO: <10.000µs 📉 -74.8%) vs baseline: +6.5% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +3.9% ✅ title_noaspectTime: ✅ 0.502µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.4% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.2% ✅ translate_aspectTime: ✅ 3.593µs (SLO: <10.000µs 📉 -64.1%) vs baseline: +8.9% Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +5.2% ✅ translate_noaspectTime: ✅ 1.043µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.2% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +3.8% ✅ upper_aspectTime: ✅ 2.464µs (SLO: <10.000µs 📉 -75.4%) vs baseline: +9.4% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +3.7% ✅ upper_noaspectTime: ✅ 0.372µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +1.1% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +3.9% 🟡 Near SLO Breach (3 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.397ms (SLO: <22.300ms -8.5%) vs baseline: -0.3% Memory: ✅ 65.251MB (SLO: <67.000MB -2.6%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.344ms (SLO: <1.450ms -7.3%) vs baseline: -0.4% Memory: ✅ 64.712MB (SLO: <67.000MB -3.4%) vs baseline: +4.8% ✅ iastTime: ✅ 20.436ms (SLO: <22.250ms -8.2%) vs baseline: +0.2% Memory: ✅ 65.157MB (SLO: <67.000MB -2.8%) vs baseline: +4.8% ✅ profilerTime: ✅ 15.250ms (SLO: <16.550ms -7.9%) vs baseline: +0.4% Memory: ✅ 53.772MB (SLO: <54.500MB 🟡 -1.3%) vs baseline: +4.6% ✅ resource-renamingTime: ✅ 20.516ms (SLO: <21.750ms -5.7%) vs baseline: +0.2% Memory: ✅ 65.233MB (SLO: <67.000MB -2.6%) vs baseline: +5.0% ✅ span-code-originTime: ✅ 25.334ms (SLO: <28.200ms 📉 -10.2%) vs baseline: +1.3% Memory: ✅ 67.396MB (SLO: <69.500MB -3.0%) vs baseline: +4.7% ✅ tracerTime: ✅ 20.483ms (SLO: <21.750ms -5.8%) vs baseline: ~same Memory: ✅ 65.205MB (SLO: <67.000MB -2.7%) vs baseline: +4.9% ✅ tracer-and-profilerTime: ✅ 22.065ms (SLO: <23.500ms -6.1%) vs baseline: +0.3% Memory: ✅ 66.749MB (SLO: <67.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ tracer-dont-create-db-spansTime: ✅ 19.270ms (SLO: <21.500ms 📉 -10.4%) vs baseline: ~same Memory: ✅ 65.168MB (SLO: <66.000MB 🟡 -1.3%) vs baseline: +4.8% ✅ tracer-minimalTime: ✅ 16.634ms (SLO: <17.500ms -4.9%) vs baseline: +0.3% Memory: ✅ 65.192MB (SLO: <66.000MB 🟡 -1.2%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 20.401ms (SLO: <21.750ms -6.2%) vs baseline: -0.5% Memory: ✅ 71.054MB (SLO: <72.500MB 🟡 -2.0%) vs baseline: +4.5% ✅ tracer-no-cachesTime: ✅ 18.410ms (SLO: <19.650ms -6.3%) vs baseline: -0.2% Memory: ✅ 65.164MB (SLO: <67.000MB -2.7%) vs baseline: +4.7% ✅ tracer-no-databasesTime: ✅ 18.744ms (SLO: <20.100ms -6.7%) vs baseline: -0.2% Memory: ✅ 65.139MB (SLO: <67.000MB -2.8%) vs baseline: +4.8% ✅ tracer-no-middlewareTime: ✅ 20.169ms (SLO: <21.500ms -6.2%) vs baseline: +0.1% Memory: ✅ 65.216MB (SLO: <67.000MB -2.7%) vs baseline: +5.0% ✅ tracer-no-templatesTime: ✅ 20.234ms (SLO: <22.000ms -8.0%) vs baseline: ~same Memory: ✅ 65.182MB (SLO: <67.000MB -2.7%) vs baseline: +4.8% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.263ms (SLO: <19.850ms -8.0%) vs baseline: +1.2% Memory: ✅ 65.163MB (SLO: <66.500MB -2.0%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.255ms (SLO: <19.400ms -5.9%) vs baseline: +0.9% Memory: ✅ 65.172MB (SLO: <66.500MB 🟡 -2.0%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 18.047ms (SLO: <19.450ms -7.2%) vs baseline: +0.2% Memory: ✅ 65.215MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.8% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.580ms (SLO: <4.750ms -3.6%) vs baseline: ~same Memory: ✅ 62.010MB (SLO: <65.000MB -4.6%) vs baseline: +5.0% ✅ appsec-postTime: ✅ 6.614ms (SLO: <6.750ms -2.0%) vs baseline: ~same Memory: ✅ 61.892MB (SLO: <65.000MB -4.8%) vs baseline: +4.6% ✅ appsec-telemetryTime: ✅ 4.567ms (SLO: <4.750ms -3.8%) vs baseline: -0.1% Memory: ✅ 62.030MB (SLO: <65.000MB -4.6%) vs baseline: +5.0% ✅ debuggerTime: ✅ 1.852ms (SLO: <2.000ms -7.4%) vs baseline: -0.3% Memory: ✅ 45.397MB (SLO: <47.000MB -3.4%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.862ms (SLO: <2.000ms -6.9%) vs baseline: +0.2% Memory: ✅ 42.408MB (SLO: <49.000MB 📉 -13.5%) vs baseline: +4.9% ✅ profilerTime: ✅ 1.913ms (SLO: <2.100ms -8.9%) vs baseline: -0.1% Memory: ✅ 46.498MB (SLO: <47.000MB 🟡 -1.1%) vs baseline: +5.0% ✅ resource-renamingTime: ✅ 3.363ms (SLO: <3.650ms -7.9%) vs baseline: -0.2% Memory: ✅ 52.258MB (SLO: <53.500MB -2.3%) vs baseline: +4.9% ✅ tracerTime: ✅ 3.349ms (SLO: <3.650ms -8.2%) vs baseline: -0.2% Memory: ✅ 52.239MB (SLO: <53.500MB -2.4%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.354ms (SLO: <3.650ms -8.1%) vs baseline: +0.2% Memory: ✅ 58.284MB (SLO: <60.000MB -2.9%) vs baseline: +4.8%
|
## Motivation The mongoengine integration does not generate any spans and only supports attaching a Pin object to the underlying pymongo client. Since we're deprecating the Pin mechanism and pymongo already fully supports the needed functionality, maintaining the mongoengine integration is redundant. ## Description This PR removes the mongoengine integration from ddtrace. The pymongo integration, which is enabled by default, will continue to provide tracing for applications using mongoengine, as mongoengine internally uses pymongo. The only notable change is that users can no longer set a Pin on the mongoengine client. Instead, they should configure the Pin directly on the pymongo client if needed. Support for the Pin API will be removed in a future release. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
This change removes the deprecated `opentracer` package from ddtrace. Note the base branch, a staging area for breaking changes slated for 4.0. --------- Co-authored-by: brettlangdon <[email protected]>
This change removes deprecated methods and method parameters from the `Span` class. Note the base branch, a staging area for breaking changes slated for 4.0. --------- Co-authored-by: brettlangdon <[email protected]>
2 participants
This branch will become the new
main, andmainwill become the last 3.x minor release.