-
Couldn't load subscription status.
- Fork 467
chore(tracing): deprecate Span.set_struct_tag and Span.get_struct_tag #14934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 240 ± 2 ms. The average import time from base is: 242 ± 2 ms. The import time difference between this PR and base is: -2.18 ± 0.08 ms. Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate brettlangdon/deprecate.set_struct_tag (02cf274) with baseline main (d36d913) 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.448ms (SLO: <22.300ms -8.3%) vs baseline: ~same Memory: ✅ 65.450MB (SLO: <67.000MB -2.3%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.344ms (SLO: <1.450ms -7.3%) vs baseline: ~same Memory: ✅ 64.532MB (SLO: <67.000MB -3.7%) vs baseline: +4.8% ✅ iastTime: ✅ 20.413ms (SLO: <22.250ms -8.3%) vs baseline: -0.2% Memory: ✅ 65.430MB (SLO: <67.000MB -2.3%) vs baseline: +4.7% ✅ profilerTime: ✅ 15.242ms (SLO: <16.550ms -7.9%) vs baseline: -0.3% Memory: ✅ 53.811MB (SLO: <54.500MB 🟡 -1.3%) vs baseline: +5.0% ✅ resource-renamingTime: ✅ 20.462ms (SLO: <21.750ms -5.9%) vs baseline: -0.2% Memory: ✅ 65.401MB (SLO: <67.000MB -2.4%) vs baseline: +4.7% ✅ span-code-originTime: ✅ 25.371ms (SLO: <28.200ms 📉 -10.0%) vs baseline: +0.3% Memory: ✅ 67.448MB (SLO: <69.500MB -3.0%) vs baseline: +4.7% ✅ tracerTime: ✅ 20.445ms (SLO: <21.750ms -6.0%) vs baseline: ~same Memory: ✅ 65.215MB (SLO: <67.000MB -2.7%) vs baseline: +4.3% ✅ tracer-and-profilerTime: ✅ 21.988ms (SLO: <23.500ms -6.4%) vs baseline: ~same Memory: ✅ 66.733MB (SLO: <67.500MB 🟡 -1.1%) vs baseline: +5.2% ✅ tracer-dont-create-db-spansTime: ✅ 19.292ms (SLO: <21.500ms 📉 -10.3%) vs baseline: -0.4% Memory: ✅ 65.436MB (SLO: <66.000MB 🟡 -0.9%) vs baseline: +4.8% ✅ tracer-minimalTime: ✅ 16.610ms (SLO: <17.500ms -5.1%) vs baseline: -0.3% Memory: ✅ 65.447MB (SLO: <66.000MB 🟡 -0.8%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 20.468ms (SLO: <21.750ms -5.9%) vs baseline: ~same Memory: ✅ 71.363MB (SLO: <72.500MB 🟡 -1.6%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 18.435ms (SLO: <19.650ms -6.2%) vs baseline: -0.3% Memory: ✅ 65.434MB (SLO: <67.000MB -2.3%) vs baseline: +4.8% ✅ tracer-no-databasesTime: ✅ 18.750ms (SLO: <20.100ms -6.7%) vs baseline: -0.3% Memory: ✅ 65.341MB (SLO: <67.000MB -2.5%) vs baseline: +4.7% ✅ tracer-no-middlewareTime: ✅ 20.148ms (SLO: <21.500ms -6.3%) vs baseline: +0.2% Memory: ✅ 65.436MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.266ms (SLO: <22.000ms -7.9%) vs baseline: -0.1% Memory: ✅ 65.411MB (SLO: <67.000MB -2.4%) vs baseline: +4.8% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.037ms (SLO: <19.850ms -9.1%) vs baseline: ~same Memory: ✅ 65.254MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ errortracking-enabled-userTime: ✅ 18.137ms (SLO: <19.400ms -6.5%) vs baseline: +0.7% Memory: ✅ 65.231MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 18.007ms (SLO: <19.450ms -7.4%) vs baseline: -0.4% Memory: ✅ 65.274MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +4.9% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.591ms (SLO: <4.750ms -3.3%) vs baseline: ~same Memory: ✅ 61.911MB (SLO: <65.000MB -4.8%) vs baseline: +5.0% ✅ appsec-postTime: ✅ 6.626ms (SLO: <6.750ms 🟡 -1.8%) vs baseline: +0.5% Memory: ✅ 62.097MB (SLO: <65.000MB -4.5%) vs baseline: +4.9% ✅ appsec-telemetryTime: ✅ 4.593ms (SLO: <4.750ms -3.3%) vs baseline: ~same Memory: ✅ 61.883MB (SLO: <65.000MB -4.8%) vs baseline: +4.7% ✅ debuggerTime: ✅ 1.857ms (SLO: <2.000ms -7.2%) vs baseline: +0.3% Memory: ✅ 45.464MB (SLO: <47.000MB -3.3%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.864ms (SLO: <2.000ms -6.8%) vs baseline: +0.3% Memory: ✅ 42.368MB (SLO: <49.000MB 📉 -13.5%) vs baseline: +4.7% ✅ profilerTime: ✅ 1.912ms (SLO: <2.100ms -8.9%) vs baseline: +0.1% Memory: ✅ 46.602MB (SLO: <47.000MB 🟡 -0.8%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 3.370ms (SLO: <3.650ms -7.7%) vs baseline: -0.2% Memory: ✅ 52.264MB (SLO: <53.500MB -2.3%) vs baseline: +4.6% ✅ tracerTime: ✅ 3.363ms (SLO: <3.650ms -7.9%) vs baseline: -0.4% Memory: ✅ 52.334MB (SLO: <53.500MB -2.2%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.367ms (SLO: <3.650ms -7.8%) vs baseline: +0.2% Memory: ✅ 58.277MB (SLO: <60.000MB -2.9%) vs baseline: +5.2% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 40.907ms (SLO: <47.150ms 📉 -13.2%) vs baseline: ~same Memory: ✅ 44.113MB (SLO: <47.000MB -6.1%) vs baseline: +4.8% ✅ add-metricsTime: ✅ 319.649ms (SLO: <344.800ms -7.3%) vs baseline: +0.4% Memory: ✅ 617.218MB (SLO: <630.000MB -2.0%) vs baseline: +5.0% ✅ add-tagsTime: ✅ 287.089ms (SLO: <314.000ms -8.6%) vs baseline: -1.3% Memory: ✅ 619.119MB (SLO: <630.000MB 🟡 -1.7%) vs baseline: +4.9% ✅ get-contextTime: ✅ 82.692ms (SLO: <92.350ms 📉 -10.5%) vs baseline: +2.1% Memory: ✅ 39.752MB (SLO: <46.500MB 📉 -14.5%) vs baseline: +4.8% ✅ is-recordingTime: ✅ 38.363ms (SLO: <44.500ms 📉 -13.8%) vs baseline: +0.5% Memory: ✅ 43.645MB (SLO: <47.500MB -8.1%) vs baseline: +5.0% ✅ record-exceptionTime: ✅ 58.346ms (SLO: <67.650ms 📉 -13.8%) vs baseline: +0.5% Memory: ✅ 40.061MB (SLO: <47.000MB 📉 -14.8%) vs baseline: +4.7% ✅ set-statusTime: ✅ 45.031ms (SLO: <50.400ms 📉 -10.7%) vs baseline: +1.6% Memory: ✅ 43.577MB (SLO: <47.000MB -7.3%) vs baseline: +4.9% ✅ startTime: ✅ 37.519ms (SLO: <43.450ms 📉 -13.6%) vs baseline: +0.4% Memory: ✅ 43.562MB (SLO: <47.000MB -7.3%) vs baseline: +4.6% ✅ start-finishTime: ✅ 82.779ms (SLO: <88.000ms -5.9%) vs baseline: +0.1% Memory: ✅ 34.564MB (SLO: <46.500MB 📉 -25.7%) vs baseline: +4.7% ✅ start-finish-telemetryTime: ✅ 84.130ms (SLO: <89.000ms -5.5%) vs baseline: -0.2% Memory: ✅ 34.544MB (SLO: <46.500MB 📉 -25.7%) vs baseline: +4.7% ✅ update-nameTime: ✅ 39.146ms (SLO: <45.150ms 📉 -13.3%) vs baseline: +0.5% Memory: ✅ 43.901MB (SLO: <47.000MB -6.6%) vs baseline: +4.9% 🟡 span - 26/26✅ add-eventTime: ✅ 20.553ms (SLO: <22.500ms -8.7%) vs baseline: ~same Memory: ✅ 49.589MB (SLO: <53.000MB -6.4%) vs baseline: +4.6% ✅ add-metricsTime: ✅ 90.937ms (SLO: <93.500ms -2.7%) vs baseline: +0.3% Memory: ✅ 689.963MB (SLO: <961.000MB 📉 -28.2%) vs baseline: +4.8% ✅ add-tagsTime: ✅ 147.988ms (SLO: <155.000ms -4.5%) vs baseline: ~same Memory: ✅ 690.584MB (SLO: <962.500MB 📉 -28.3%) vs baseline: +4.8% ✅ get-contextTime: ✅ 18.851ms (SLO: <20.500ms -8.0%) vs baseline: ~same Memory: ✅ 48.395MB (SLO: <53.000MB -8.7%) vs baseline: +4.7% ✅ is-recordingTime: ✅ 19.152ms (SLO: <20.500ms -6.6%) vs baseline: +0.8% Memory: ✅ 48.453MB (SLO: <53.000MB -8.6%) vs baseline: +4.8% ✅ record-exceptionTime: ✅ 38.906ms (SLO: <40.000ms -2.7%) vs baseline: +3.4% Memory: ✅ 42.455MB (SLO: <53.000MB 📉 -19.9%) vs baseline: +4.9% ✅ set-statusTime: ✅ 20.660ms (SLO: <22.000ms -6.1%) vs baseline: +0.4% Memory: ✅ 48.428MB (SLO: <53.000MB -8.6%) vs baseline: +4.8% ✅ startTime: ✅ 18.778ms (SLO: <20.500ms -8.4%) vs baseline: -0.4% Memory: ✅ 48.394MB (SLO: <53.000MB -8.7%) vs baseline: +4.8% ✅ start-finishTime: ✅ 51.995ms (SLO: <52.500ms 🟡 -1.0%) vs baseline: +1.2% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ start-finish-telemetryTime: ✅ 53.300ms (SLO: <54.500ms -2.2%) vs baseline: +0.8% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.8% ✅ start-finish-traceid128Time: ✅ 54.873ms (SLO: <57.000ms -3.7%) vs baseline: ~same Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.7% ✅ start-traceid128Time: ✅ 19.264ms (SLO: <22.500ms 📉 -14.4%) vs baseline: +0.4% Memory: ✅ 48.393MB (SLO: <53.000MB -8.7%) vs baseline: +4.8% ✅ update-nameTime: ✅ 19.585ms (SLO: <22.000ms 📉 -11.0%) vs baseline: +2.0% Memory: ✅ 49.160MB (SLO: <53.000MB -7.2%) vs baseline: +5.1%
|
Description
This was only meant as an internal only API, not to be used by customers.
We do not want to fully support this API for customer use at this time.
Testing
Risks
Additional Notes