Skip to content

chore(llmobs): missed updates in span kind key changes #14718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2025
+2 −2
Merged

chore(llmobs): missed updates in span kind key changes #14718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ddtrace/llmobs/_telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def _find_tag_value_from_tags(tags, tag_key):


def _get_tags_from_span_event(event: LLMObsSpanEvent):
span_kind = event.get("meta", {}).get("span.kind", "")
span_kind = event.get("meta", {}).get("span", {}).get("kind", "")
integration = _find_tag_value_from_tags(event.get("tags", []), "integration")
ml_app = _find_tag_value_from_tags(event.get("tags", []), "ml_app")
autoinstrumented = integration is not None
Expand Down
2 changes: 1 addition & 1 deletion tests/llmobs/test_llmobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,5 +678,5 @@ def test_apm_traces_dropped_when_disabled(llmobs, llmobs_events, tracer, llmobs_
# But LLMObs events should still be sent
assert len(llmobs_events) == 1
llm_event = llmobs_events[0]
assert llm_event["meta"]["span.kind"] == "llm"
assert llm_event["meta"]["span"]["kind"] == "llm"
assert llm_event["meta"]["model_name"] == "test-model"
Loading