-
Notifications
You must be signed in to change notification settings - Fork 457
chore(llmobs): [MLOB-3042] improve llmobs span event #14600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 240 ± 3 ms. The average import time from base is: 243 ± 4 ms. The import time difference between this PR and base is: -2.9 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate nicole-cybul/improve-llmobs-span-event (3bf4471) with baseline main (b7d99dc) 📈 Performance Regressions (2 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.401µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.4% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ add_inplace_aspectTime: ✅ 0.410µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.9% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ add_inplace_noaspectTime: ✅ 0.317µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +0.4% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ add_noaspectTime: ✅ 0.278µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.3% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.2% ✅ bytearray_aspectTime: ✅ 1.341µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +0.8% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ bytearray_extend_aspectTime: ✅ 1.554µs (SLO: <10.000µs 📉 -84.5%) vs baseline: +7.6% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ bytearray_extend_noaspectTime: ✅ 0.611µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -0.3% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ bytearray_noaspectTime: ✅ 0.488µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.7% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.7% ✅ bytes_aspectTime: ✅ 1.335µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +3.3% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.1% ✅ bytes_noaspectTime: ✅ 0.488µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.8% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.7% ✅ bytesio_aspectTime: ✅ 1.363µs (SLO: <10.000µs 📉 -86.4%) vs baseline: +2.8% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ bytesio_noaspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.5% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ capitalize_aspectTime: ✅ 0.731µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.6% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.8% ✅ capitalize_noaspectTime: ✅ 0.436µs (SLO: <10.000µs 📉 -95.6%) vs baseline: +1.1% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.1% ✅ casefold_aspectTime: ✅ 0.747µs (SLO: <10.000µs 📉 -92.5%) vs baseline: +2.0% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ casefold_noaspectTime: ✅ 0.369µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.4% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ decode_aspectTime: ✅ 0.724µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +0.2% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ decode_noaspectTime: ✅ 0.417µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.3% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ encode_aspectTime: ✅ 0.713µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +0.9% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ encode_noaspectTime: ✅ 0.400µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.6% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ format_aspectTime: ✅ 3.455µs (SLO: <10.000µs 📉 -65.4%) vs baseline: +1.3% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ format_map_aspectTime: ✅ 3.597µs (SLO: <10.000µs 📉 -64.0%) vs baseline: -1.3% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ format_map_noaspectTime: ✅ 0.774µs (SLO: <10.000µs 📉 -92.3%) vs baseline: +0.3% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ format_noaspectTime: ✅ 0.600µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.2% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ index_aspectTime: ✅ 0.359µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +1.1% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ index_noaspectTime: ✅ 0.278µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.7% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ join_aspectTime: ✅ 1.333µs (SLO: <10.000µs 📉 -86.7%) vs baseline: -2.1% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.6% ✅ join_noaspectTime: ✅ 0.485µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -1.9% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ ljust_aspectTime: ✅ 2.586µs (SLO: <20.000µs 📉 -87.1%) vs baseline: -0.4% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ ljust_noaspectTime: ✅ 0.403µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.4% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ lower_aspectTime: ✅ 2.261µs (SLO: <10.000µs 📉 -77.4%) vs baseline: +1.9% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ lower_noaspectTime: ✅ 0.367µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.2% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ lstrip_aspectTime: ✅ 2.248µs (SLO: <20.000µs 📉 -88.8%) vs baseline: -2.2% Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +5.1% ✅ lstrip_noaspectTime: ✅ 0.383µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.6% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.6% ✅ modulo_aspectTime: ✅ 1.013µs (SLO: <10.000µs 📉 -89.9%) vs baseline: +1.5% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.533µs (SLO: <10.000µs 📉 -84.7%) vs baseline: +0.2% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ modulo_aspect_for_bytesTime: ✅ 0.985µs (SLO: <10.000µs 📉 -90.2%) vs baseline: +0.4% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.238µs (SLO: <10.000µs 📉 -87.6%) vs baseline: +2.8% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.6% ✅ modulo_noaspectTime: ✅ 0.629µs (SLO: <10.000µs 📉 -93.7%) vs baseline: -0.1% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ replace_aspectTime: ✅ 5.051µs (SLO: <10.000µs 📉 -49.5%) vs baseline: +3.1% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ replace_noaspectTime: ✅ 0.462µs (SLO: <10.000µs 📉 -95.4%) vs baseline: ~same Memory: ✅ 37.591MB (SLO: <39.000MB -3.6%) vs baseline: +4.5% ✅ repr_aspectTime: ✅ 0.903µs (SLO: <10.000µs 📉 -91.0%) vs baseline: -0.5% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ repr_noaspectTime: ✅ 0.418µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.9% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.6% ✅ rstrip_aspectTime: ✅ 1.908µs (SLO: <20.000µs 📉 -90.5%) vs baseline: -0.7% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ rstrip_noaspectTime: ✅ 0.380µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.8% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ slice_aspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: ~same Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ slice_noaspectTime: ✅ 0.448µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +0.5% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.6% ✅ stringio_aspectTime: ✅ 1.755µs (SLO: <10.000µs 📉 -82.5%) vs baseline: 📈 +13.3% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ stringio_noaspectTime: ✅ 0.724µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +0.3% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ strip_aspectTime: ✅ 2.204µs (SLO: <20.000µs 📉 -89.0%) vs baseline: -3.0% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.1% ✅ strip_noaspectTime: ✅ 0.389µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +2.0% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ swapcase_aspectTime: ✅ 2.449µs (SLO: <10.000µs 📉 -75.5%) vs baseline: +2.1% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ swapcase_noaspectTime: ✅ 0.535µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +0.9% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ title_aspectTime: ✅ 2.387µs (SLO: <10.000µs 📉 -76.1%) vs baseline: +2.2% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ title_noaspectTime: ✅ 0.506µs (SLO: <10.000µs 📉 -94.9%) vs baseline: +1.0% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ translate_aspectTime: ✅ 3.247µs (SLO: <10.000µs 📉 -67.5%) vs baseline: ~same Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.1% ✅ translate_noaspectTime: ✅ 1.038µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.3% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ upper_aspectTime: ✅ 2.266µs (SLO: <10.000µs 📉 -77.3%) vs baseline: +3.0% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ upper_noaspectTime: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: ~same Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.379µs (SLO: <10.000µs 📉 -56.2%) vs baseline: -0.2% Memory: ✅ 37.591MB (SLO: <39.000MB -3.6%) vs baseline: +4.6% ✅ ospathbasename_noaspectTime: ✅ 1.085µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -0.3% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ ospathjoin_aspectTime: ✅ 6.126µs (SLO: <10.000µs 📉 -38.7%) vs baseline: +1.2% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathjoin_noaspectTime: ✅ 2.292µs (SLO: <10.000µs 📉 -77.1%) vs baseline: -0.6% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ ospathnormcase_aspectTime: ✅ 3.948µs (SLO: <10.000µs 📉 -60.5%) vs baseline: 📈 +14.1% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathnormcase_noaspectTime: ✅ 0.560µs (SLO: <10.000µs 📉 -94.4%) vs baseline: -2.5% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ ospathsplit_aspectTime: ✅ 4.729µs (SLO: <10.000µs 📉 -52.7%) vs baseline: -4.4% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.1% ✅ ospathsplit_noaspectTime: ✅ 1.607µs (SLO: <10.000µs 📉 -83.9%) vs baseline: +0.5% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ ospathsplitdrive_aspectTime: ✅ 3.676µs (SLO: <10.000µs 📉 -63.2%) vs baseline: -0.1% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.6% ✅ ospathsplitdrive_noaspectTime: ✅ 0.695µs (SLO: <10.000µs 📉 -93.1%) vs baseline: -0.5% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ ospathsplitext_aspectTime: ✅ 4.564µs (SLO: <10.000µs 📉 -54.4%) vs baseline: ~same Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.6% ✅ ospathsplitext_noaspectTime: ✅ 1.383µs (SLO: <10.000µs 📉 -86.2%) vs baseline: +0.4% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +5.0% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.518ms (SLO: <22.300ms -8.0%) vs baseline: -0.3% Memory: ✅ 65.444MB (SLO: <67.000MB -2.3%) vs baseline: +5.1% ✅ exception-replay-enabledTime: ✅ 1.354ms (SLO: <1.450ms -6.6%) vs baseline: +0.6% Memory: ✅ 64.457MB (SLO: <67.000MB -3.8%) vs baseline: +5.2% ✅ iastTime: ✅ 20.501ms (SLO: <22.250ms -7.9%) vs baseline: +0.2% Memory: ✅ 65.347MB (SLO: <67.000MB -2.5%) vs baseline: +4.9% ✅ profilerTime: ✅ 15.346ms (SLO: <16.550ms -7.3%) vs baseline: +0.6% Memory: ✅ 53.645MB (SLO: <54.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 20.545ms (SLO: <21.750ms -5.5%) vs baseline: +0.3% Memory: ✅ 65.370MB (SLO: <67.000MB -2.4%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 26.163ms (SLO: <28.200ms -7.2%) vs baseline: -0.2% Memory: ✅ 67.483MB (SLO: <69.500MB -2.9%) vs baseline: +4.9% ✅ tracerTime: ✅ 20.531ms (SLO: <21.750ms -5.6%) vs baseline: +0.3% Memory: ✅ 65.500MB (SLO: <67.000MB -2.2%) vs baseline: +5.1% ✅ tracer-and-profilerTime: ✅ 22.055ms (SLO: <23.500ms -6.1%) vs baseline: -0.1% Memory: ✅ 66.739MB (SLO: <67.500MB 🟡 -1.1%) vs baseline: +5.5% ✅ tracer-dont-create-db-spansTime: ✅ 19.403ms (SLO: <21.500ms -9.8%) vs baseline: +0.1% Memory: ✅ 65.512MB (SLO: <66.000MB 🟡 -0.7%) vs baseline: +5.1% ✅ tracer-minimalTime: ✅ 16.619ms (SLO: <17.500ms -5.0%) vs baseline: -0.4% Memory: ✅ 65.166MB (SLO: <66.000MB 🟡 -1.3%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 20.487ms (SLO: <21.750ms -5.8%) vs baseline: -0.1% Memory: ✅ 71.343MB (SLO: <72.500MB 🟡 -1.6%) vs baseline: +5.1% ✅ tracer-no-cachesTime: ✅ 18.472ms (SLO: <19.650ms -6.0%) vs baseline: ~same Memory: ✅ 65.460MB (SLO: <67.000MB -2.3%) vs baseline: +5.1% ✅ tracer-no-databasesTime: ✅ 18.840ms (SLO: <20.100ms -6.3%) vs baseline: +0.2% Memory: ✅ 65.167MB (SLO: <67.000MB -2.7%) vs baseline: +5.2% ✅ tracer-no-middlewareTime: ✅ 20.174ms (SLO: <21.500ms -6.2%) vs baseline: -0.2% Memory: ✅ 65.410MB (SLO: <67.000MB -2.4%) vs baseline: +5.0% ✅ tracer-no-templatesTime: ✅ 20.317ms (SLO: <22.000ms -7.6%) vs baseline: +0.2% Memory: ✅ 65.510MB (SLO: <67.000MB -2.2%) vs baseline: +5.1% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.169ms (SLO: <19.850ms -8.5%) vs baseline: +0.4% Memory: ✅ 65.294MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ errortracking-enabled-userTime: ✅ 18.073ms (SLO: <19.400ms -6.8%) vs baseline: +0.2% Memory: ✅ 65.392MB (SLO: <66.500MB 🟡 -1.7%) vs baseline: +5.1% ✅ tracer-enabledTime: ✅ 18.053ms (SLO: <19.450ms -7.2%) vs baseline: -0.1% Memory: ✅ 65.313MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +5.0% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.582ms (SLO: <4.750ms -3.5%) vs baseline: ~same Memory: ✅ 61.912MB (SLO: <65.000MB -4.8%) vs baseline: +3.0% ✅ appsec-postTime: ✅ 6.572ms (SLO: <6.750ms -2.6%) vs baseline: -0.2% Memory: ✅ 61.971MB (SLO: <65.000MB -4.7%) vs baseline: +3.0% ✅ appsec-telemetryTime: ✅ 4.581ms (SLO: <4.750ms -3.6%) vs baseline: ~same Memory: ✅ 61.932MB (SLO: <65.000MB -4.7%) vs baseline: +3.0% ✅ debuggerTime: ✅ 1.857ms (SLO: <2.000ms -7.2%) vs baseline: -0.5% Memory: ✅ 45.456MB (SLO: <47.000MB -3.3%) vs baseline: +5.3% ✅ iast-getTime: ✅ 1.865ms (SLO: <2.000ms -6.8%) vs baseline: +0.6% Memory: ✅ 42.349MB (SLO: <49.000MB 📉 -13.6%) vs baseline: +4.9% ✅ profilerTime: ✅ 1.909ms (SLO: <2.100ms -9.1%) vs baseline: -0.2% Memory: ✅ 46.458MB (SLO: <47.000MB 🟡 -1.2%) vs baseline: +8.1% ✅ resource-renamingTime: ✅ 3.388ms (SLO: <3.650ms -7.2%) vs baseline: ~same Memory: ✅ 52.199MB (SLO: <53.500MB -2.4%) vs baseline: +5.0% ✅ tracerTime: ✅ 3.380ms (SLO: <3.650ms -7.4%) vs baseline: +0.2% Memory: ✅ 52.258MB (SLO: <53.500MB -2.3%) vs baseline: +5.1% ✅ tracer-nativeTime: ✅ 3.382ms (SLO: <3.650ms -7.4%) vs baseline: +0.2% Memory: ✅ 58.243MB (SLO: <60.000MB -2.9%) vs baseline: +5.3% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.946ms (SLO: <4.200ms -6.1%) vs baseline: ~same Memory: ✅ 62.167MB (SLO: <66.000MB -5.8%) vs baseline: +3.0% ✅ iast-enabledTime: ✅ 2.463ms (SLO: <2.800ms 📉 -12.0%) vs baseline: +0.7% Memory: ✅ 59.081MB (SLO: <60.000MB 🟡 -1.5%) vs baseline: +5.2% ✅ tracer-enabledTime: ✅ 2.076ms (SLO: <2.250ms -7.7%) vs baseline: -0.5% Memory: ✅ 52.121MB (SLO: <54.500MB -4.4%) vs baseline: +5.1% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 45.464ms (SLO: <47.150ms -3.6%) vs baseline: +0.3% Memory: ✅ 45.261MB (SLO: <47.000MB -3.7%) vs baseline: +5.2% ✅ add-metricsTime: ✅ 321.809ms (SLO: <344.800ms -6.7%) vs baseline: +0.6% Memory: ✅ 552.579MB (SLO: <562.000MB 🟡 -1.7%) vs baseline: +4.5% ✅ add-tagsTime: ✅ 291.213ms (SLO: <314.000ms -7.3%) vs baseline: +0.6% Memory: ✅ 555.098MB (SLO: <563.500MB 🟡 -1.5%) vs baseline: +4.9% ✅ get-contextTime: ✅ 83.071ms (SLO: <92.350ms 📉 -10.0%) vs baseline: +0.7% Memory: ✅ 40.262MB (SLO: <46.500MB 📉 -13.4%) vs baseline: +5.1% ✅ is-recordingTime: ✅ 42.936ms (SLO: <44.500ms -3.5%) vs baseline: +0.2% Memory: ✅ 44.653MB (SLO: <47.500MB -6.0%) vs baseline: +5.1% ✅ record-exceptionTime: ✅ 61.723ms (SLO: <67.650ms -8.8%) vs baseline: +0.1% Memory: ✅ 40.551MB (SLO: <47.000MB 📉 -13.7%) vs baseline: +5.0% ✅ set-statusTime: ✅ 48.814ms (SLO: <50.400ms -3.1%) vs baseline: +0.3% Memory: ✅ 44.614MB (SLO: <47.000MB -5.1%) vs baseline: +5.0% ✅ startTime: ✅ 43.050ms (SLO: <43.450ms 🟡 -0.9%) vs baseline: +2.3% Memory: ✅ 44.595MB (SLO: <47.000MB -5.1%) vs baseline: +4.9% ✅ start-finishTime: ✅ 83.093ms (SLO: <88.000ms -5.6%) vs baseline: ~same Memory: ✅ 34.603MB (SLO: <46.500MB 📉 -25.6%) vs baseline: +5.0% ✅ start-finish-telemetryTime: ✅ 84.445ms (SLO: <89.000ms -5.1%) vs baseline: -0.5% Memory: ✅ 34.583MB (SLO: <46.500MB 📉 -25.6%) vs baseline: +4.9% ✅ update-nameTime: ✅ 44.391ms (SLO: <45.150ms 🟡 -1.7%) vs baseline: +0.6% Memory: ✅ 44.929MB (SLO: <47.000MB -4.4%) vs baseline: +5.2%
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice! i also gave it a quick local test because i for some reason thought that changing it such that we have
span.kind
→span: { "kind": ... }
{ "error.message": ..., "error.stack": ... }
→{ "error": { "message": ..., "stack": ... } }
would cause issues, but it doesn't seem so, as it probably unmarshalls the same in our backend 😅
thanks for taking this on, just a couple small questions/ideas, but otherwise lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great for the most part! Just a couple minor suggestions/questions
The goal of this PR is to support better type checking for the
LLMObsSpanEvent
class to match what our backend expects for spans (here). I have tried to replace all of the instances where we are using regular dictionaries in favor of using theTypedDict
objects we have defined, resolving the static type hint errors that have popped up as a result. There is likely to be some places in the code that I have overlooked, but we can continue transitioning to the new format as time goes on.Checklist
Reviewer Checklist