Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openai): test with Python 3.13 #12014

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(openai): test with Python 3.13 #12014

wants to merge 2 commits into from

Conversation

Yun-Kim
Copy link
Contributor

@Yun-Kim Yun-Kim commented Jan 21, 2025

Resolves #11994.

We were previously not testing our OpenAI integration with Python versions >= 3.12 (at the time, OpenAI did not support those newer Python versions). We recently saw that our bytecode wrapping for OpenAI methods broke in Python 3.13, so this PR attempts to address that:

  • Switch out our bytecode wrapping with wrapt.wrap_function_wrapper() to make our patching compatible with newer Python versions.
  • Add Python 3.12 and 3.13 to tested versions for the OpenAI integration.
  • Implements unpatching and adds patching tests

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

- Switch bytecode wrapping with wrapt.wrap_function_wrapper
- Implement unpatching
- Add patching tests
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 21, 2025

Datadog Report

Branch report: yunkim/openai-313
Commit report: eb89b5d
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 27.33s Total duration (35m 38.06s time saved)

Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/contrib/internal/openai/patch.py                                @DataDog/ml-observability
riotfile.py                                                             @DataDog/apm-python
tests/contrib/openai/test_openai_patch.py                               @DataDog/ml-observability
tests/contrib/openai/test_openai_v0.py                                  @DataDog/ml-observability
tests/contrib/openai/test_openai_v1.py                                  @DataDog/ml-observability

@pr-commenter
Copy link

pr-commenter bot commented Jan 21, 2025

Benchmarks

Benchmark execution time: 2025-01-21 22:38:26

Comparing candidate commit eb89b5d in PR branch yunkim/openai-313 with baseline commit 0003501 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: ddtrace breaks using openai sdk on python 3.13
1 participant