Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set span error metadata only for escaped errors #12004

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dubloom
Copy link
Contributor

@dubloom dubloom commented Jan 20, 2025

Before this change we set some span error metadata for every call of record_exception. This would set the span as an errored span. However, we can call several times record_exception within a span and we can pass handled exceptions as arguments. In the later case, we want the span not to be errored.

This change aims at addressing this. We will set the relevant metadata only if the error is escaped (which means unhandled).

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Sorry, something went wrong.

@dubloom dubloom requested a review from mabdinur January 20, 2025 09:37
@dubloom dubloom requested review from a team as code owners January 20, 2025 09:37
@dubloom dubloom requested a review from tabgok January 20, 2025 09:37
Copy link
Contributor

github-actions bot commented Jan 20, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/fix-otel-record-exception-api-17f3a4b23948ec79.yaml  @DataDog/apm-python
ddtrace/internal/opentelemetry/span.py                                  @DataDog/apm-sdk-api-python
tests/snapshots/tests.opentelemetry.test_trace.test_otel_start_span_record_exception.json  @DataDog/apm-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: dubloom/fix-otel-record-exception
Commit report: dea936a
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 29.24s Total duration (35m 10.64s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 20, 2025

Benchmarks

Benchmark execution time: 2025-02-17 08:57:29

Comparing candidate commit b4e22fb in PR branch dubloom/fix-otel-record-exception with baseline commit 0c7fc1b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 418 metrics, 2 unstable metrics.

dubloom and others added 3 commits February 14, 2025 13:04
Co-authored-by: datadog-datadog-prod-us1[bot] <88084959+datadog-datadog-prod-us1[bot]@users.noreply.github.com>
@mabdinur mabdinur force-pushed the dubloom/fix-otel-record-exception branch from ec69876 to 5c59c35 Compare February 14, 2025 18:05
Copy link
Contributor

@mabdinur mabdinur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I clean up the commit history and left one suggestion.

Overall looks good to me!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…c79.yaml

Co-authored-by: Munir Abdinur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants