-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set span error metadata only for escaped errors #12004
base: main
Are you sure you want to change the base?
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 29.24s Total duration (35m 10.64s time saved) |
BenchmarksBenchmark execution time: 2025-02-17 08:57:29 Comparing candidate commit b4e22fb in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 418 metrics, 2 unstable metrics. |
…exception escaped
Co-authored-by: datadog-datadog-prod-us1[bot] <88084959+datadog-datadog-prod-us1[bot]@users.noreply.github.com>
ec69876
to
5c59c35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I clean up the commit history and left one suggestion.
Overall looks good to me!
releasenotes/notes/fix-otel-record-exception-api-17f3a4b23948ec79.yaml
Outdated
Show resolved
Hide resolved
…c79.yaml Co-authored-by: Munir Abdinur <[email protected]>
Before this change we set some span error metadata for every call of record_exception. This would set the span as an errored span. However, we can call several times record_exception within a span and we can pass handled exceptions as arguments. In the later case, we want the span not to be errored.
This change aims at addressing this. We will set the relevant metadata only if the error is escaped (which means unhandled).
Checklist
Reviewer Checklist