-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: enable vpa for jobs in the package stage #11928
base: main
Are you sure you want to change the base?
ci: enable vpa for jobs in the package stage #11928
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1468 Skipped, 3m 59.33s Total duration (27m 43.04s time saved) |
BenchmarksBenchmark execution time: 2025-01-27 12:51:40 Comparing candidate commit 63632b6 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
Hi @danielrs975 , this is a nice win 💰 I took a look at the dashboard you linked, and it looks like this is aggregated across all branches, so it's a bit harder to tell the before/after impact of doing this. I tried to filter down to your branch specifically, but it won't let me do that for some reason. The fix LGTM, but just wanted to visualize the impact before we merged to main! |
Hello, sorry for the late response, we are trying to generate traffic from this branch to approximate the impact. However we implemented a way to have this variable automatically injected to 20% of the jobs. I need to check with my team but probably we going that way. For the filtering by branch I added a new template variable |
/gitlab trigger-ci |
Devflow running:
|
/gitlab trigger-ci |
Devflow running:
|
/gitlab trigger-ci |
Devflow running:
|
Devflow running:
|
Motivation
By observing this dashboard, filtering jobs by the
package
stage, I could see that most of those jobs use less CPU that the one requested. In an effort to make saving through right sizing CI workloads we, CI team, started to use VPA for it.Data obtained from here
Changes
Tests
Checklist
Reviewer Checklist