Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable vpa for jobs in the package stage #11928

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danielrs975
Copy link

@danielrs975 danielrs975 commented Jan 14, 2025

Motivation

By observing this dashboard, filtering jobs by the package stage, I could see that most of those jobs use less CPU that the one requested. In an effort to make saving through right sizing CI workloads we, CI team, started to use VPA for it.

Data obtained from here

Changes

  • Enable VPA for the jobs in the package stage.

Tests

  • Check in this job that the labels were added correctly

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

CODEOWNERS have been resolved as:

.gitlab/package.yml                                                     @DataDog/python-guild @DataDog/apm-core-python

@danielrs975 danielrs975 marked this pull request as ready for review January 14, 2025 10:19
@danielrs975 danielrs975 requested review from a team as code owners January 14, 2025 10:19
@danielrs975 danielrs975 changed the title enable vpa for jobs in the package stage [CIPO-5] enable vpa for jobs in the package stage Jan 14, 2025
@danielrs975 danielrs975 changed the title [CIPO-5] enable vpa for jobs in the package stage ci: enable vpa for jobs in the package stage Jan 14, 2025
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: danielrs975/cipo-5/enable-vpa-for-package-stage-jobs
Commit report: 63632b6
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 3m 59.33s Total duration (27m 43.04s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 14, 2025

Benchmarks

Benchmark execution time: 2025-01-27 12:51:40

Comparing candidate commit 63632b6 in PR branch danielrs975/cipo-5/enable-vpa-for-package-stage-jobs with baseline commit b13bcb0 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@erikayasuda
Copy link
Contributor

Hi @danielrs975 , this is a nice win 💰 I took a look at the dashboard you linked, and it looks like this is aggregated across all branches, so it's a bit harder to tell the before/after impact of doing this. I tried to filter down to your branch specifically, but it won't let me do that for some reason. The fix LGTM, but just wanted to visualize the impact before we merged to main!

@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 21, 2025
@danielrs975
Copy link
Author

danielrs975 commented Jan 27, 2025

Hi @danielrs975 , this is a nice win 💰 I took a look at the dashboard you linked, and it looks like this is aggregated across all branches, so it's a bit harder to tell the before/after impact of doing this. I tried to filter down to your branch specifically, but it won't let me do that for some reason. The fix LGTM, but just wanted to visualize the impact before we merged to main!

Hello, sorry for the late response, we are trying to generate traffic from this branch to approximate the impact. However we implemented a way to have this variable automatically injected to 20% of the jobs. I need to check with my team but probably we going that way.

For the filtering by branch I added a new template variable ci-branch

https://app.datadoghq.com/dashboard/er4-5bc-ui2/cipo-ci-jobs-vpa-migration?fromUser=true&refresh_mode=sliding&tpl_var_ci_project_name%5B0%5D=dd-trace-py&tpl_var_ci-branch%5B0%5D=%22danielrs975%2Fcipo-5%2Fenable-vpa-for-package-stage-jobs%22&tpl_var_ci-job-stage%5B0%5D=package&from_ts=1737955378945&to_ts=1737969778945&live=true

@danielrs975
Copy link
Author

/gitlab trigger-ci

@dd-devflow
Copy link

dd-devflow bot commented Jan 27, 2025

Devflow running: /gitlab trigger-ci

View all feedbacks in Devflow UI.


2025-01-27 09:17:45 UTC ℹ️ Gitlab pipeline started

Started pipeline #54029947

@danielrs975
Copy link
Author

/gitlab trigger-ci

@dd-devflow
Copy link

dd-devflow bot commented Jan 27, 2025

Devflow running: /gitlab trigger-ci

View all feedbacks in Devflow UI.


2025-01-27 11:50:11 UTC ℹ️ Gitlab pipeline started

Started pipeline #54044311

@danielrs975
Copy link
Author

/gitlab trigger-ci

@dd-devflow
Copy link

dd-devflow bot commented Jan 27, 2025

Devflow running: /gitlab trigger-ci

View all feedbacks in Devflow UI.


2025-01-27 12:10:07 UTC ℹ️ Gitlab pipeline started

Started pipeline #54045573

@dd-devflow
Copy link

dd-devflow bot commented Jan 27, 2025

Devflow running: /gitlab trigger-ci

View all feedbacks in Devflow UI.


2025-01-27 12:10:11 UTC ℹ️ Devflow: /gitlab trigger-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants