-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SSRF #3014
base: master
Are you sure you want to change the base?
Implement SSRF #3014
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3014 +/- ##
============================================
- Coverage 74.79% 74.75% -0.05%
- Complexity 2787 2791 +4
============================================
Files 112 112
Lines 11033 11039 +6
============================================
Hits 8252 8252
- Misses 2781 2787 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Benchmarks [ tracer ]Benchmark execution time: 2025-01-03 12:12:49 Comparing candidate commit 537c557 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 178 metrics, 0 unstable metrics. |
f1126a6
to
550a82e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem sufficient to actually subscribe to the ASM_RASP_*
products. In fact, it seems we're not subscribed even to ASM_RASP_LFI
(see the logic in ddog_init_remote_config
).
To avoid these situations, I would strong recommend that you implement an appsec/tests/integration test that submits the RASP configuration via remote config.
Anil brought to me attention the fact that there are no new products related to RASP, only capabilities. So:
|
97afd73
to
1933051
Compare
1933051
to
b514593
Compare
Description
Expand rasp capabilities with SSRF. This PR changes also the php method
push_address
. The reason is that now there are php functions which need to push mulitple addresses. Each call topush_address
was doing a call to the WAF. This method has been changed topush_addresses
allowing to push one or more at the same time.APPSEC-52930
Reviewer checklist